Fix thread joining in dt_control_shutdown()#20039
Merged
TurboGit merged 1 commit intodarktable-org:masterfrom Jan 3, 2026
Merged
Fix thread joining in dt_control_shutdown()#20039TurboGit merged 1 commit intodarktable-org:masterfrom
TurboGit merged 1 commit intodarktable-org:masterfrom
Conversation
The last thread of num_threads clearly missed joining. Introduced in 77bed88
Collaborator
Author
|
Also safe for 5.4.1 |
Collaborator
Author
|
@TurboGit i checked this again, it's pretty hard to trigger an "issue" as you have to add a job running in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last thread of num_threads clearly missed joining. Introduced in 77bed88
@dterrahe hinted to this in #20002, i can't remember how that happened in 77bed88 and if/how i oversaw the mentioned discussion.