Skip to content

Conversation

@jenshannoschwalm
Copy link
Collaborator

The last thread of num_threads clearly missed joining. Introduced in 77bed88

@dterrahe hinted to this in #20002, i can't remember how that happened in 77bed88 and if/how i oversaw the mentioned discussion.

The last thread of num_threads clearly missed joining.
Introduced in 77bed88
@jenshannoschwalm jenshannoschwalm added the bugfix pull request fixing a bug label Dec 30, 2025
@jenshannoschwalm jenshannoschwalm added this to the 5.6 milestone Dec 30, 2025
@jenshannoschwalm
Copy link
Collaborator Author

Also safe for 5.4.1

@jenshannoschwalm jenshannoschwalm modified the milestones: 5.6, 5.4.1 Jan 2, 2026
@jenshannoschwalm
Copy link
Collaborator Author

@TurboGit i checked this again, it's pretty hard to trigger an "issue" as you have to add a job running in num_threads-1 but in that case the job thread is not joined so it's "running-in-the-wild" after control closing leading to an invisible crash while dt is closing. So for me also for 5.4.1

Copy link
Member

@TurboGit TurboGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TurboGit TurboGit merged commit 56a2f70 into darktable-org:master Jan 3, 2026
5 checks passed
@jenshannoschwalm jenshannoschwalm deleted the fix_pthread_joining branch January 3, 2026 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix pull request fixing a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants