fix export overwrite if changed

[zisoft]

The function now checks against the exported file's modification time stamp instead of the export time stamp in the database. This makes a lot more sense especially when using the multi-preset export with different formats in multiple directories.

See #15404 (comment) and #19987 (comment)

[DaveInDev]

hi @zisoft , thanks for your help : I will check tomorrow on the next nightly build.

[zisoft]

@DaveInDev: This is only included in the nightly build after the PR is merged.

[DaveInDev]

@zisoft I'm not familiar with github. Do you mean that it won't appear in tomorrow's build ? Is there another way to test this change ?

[TurboGit]

Given the comment: #19987 (comment) I'll pass this as draft.

[zisoft]

@TurboGit @DaveInDev

Got it

The params for the format module were read during the running job.
Now the params are read at job creation and passed to _control_export_job_run

Steps to test:

• create two jpeg export presets, one with quality 10 and one with quality 90 and set their output to different directories or filenames
• start a multi-preset export with these two presets
• compare the different file sizes

For the overwrite if changed:

• create a preset with "on conflict": overwrite if changed
• start the export, the file should be created only once if no develop changes were made

[DaveInDev]

Thanks a lot @zisoft . As I'm not too familiar with github (I read "Changes can be cleanly merged"), would I be able to test this correction on tomorrow's nightly build ?

[zisoft]

@DaveInDev the changes need to be reviewed by @TurboGit first.
Once the PR is merged you can then test with the next nightly build afterwards.

[TurboGit]

Some style comments and possibly a memory leak.

[TurboGit]

@zisoft : Also, let me know if you feel this safe enough for 5.4.1. It seems to me, so I'm in favor of a merge in 5.4.1 but you'll have the final word.

[zisoft]

I made a lot of tests with different scenarios. Should be safe for 5.4.1

[zisoft]

Release notes:

Fixed wrong handling of overwrite if changed in export.

Fixed images exported with wrong settings when using multi-preset export.

[DaveInDev]

hi @zisoft , I saw this "[force-pushed]", but I don't know if your modifications are in the latest nightly build of january 03 ?

[zisoft]

@DaveInDev : No, as long as this PR is not merged the changes are not included in the nightly build.

[TurboGit]

Thanks!