-
Notifications
You must be signed in to change notification settings - Fork 1.3k
imageio: don't hide quality slider for webp lossless #14868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Quality for lossless seems suspect to me. So I tried it and in all cases changing the quality slider from 20% to 100% does not change the size of the exported image. So what does this slider do? Maybe that's the tooltip that should be fixed, no? |
Haven't tested myself, but this is what the libwebp API says/claims as well: |
|
Ok, the doc is: But clearly this does not work on our side. Maybe there is an additional parameter to set... Reading again the doc above, it seems that for lossless we have only 0% or 100% working. Indeed with 100% it takes some more time and the file size is a bit smaller (23.1Mb instead of 23.4MB). For anything < 100% the speed seems to be the same and the size always 23.4Mb. So it looks like more an option saying : "optimize for speed", "optimize for size". If this is confirmed somehow, maybe the best option would be to have another slider with more user friendly semantic. |
|
TBH, I wasn't planning to dig deeper into this, the idea was to just align the UI to the API/tooltip when I noticed the difference... |
|
At this stage let's reschedule that for 4.8. |
The tooltip also mentions it for lossless (affects speed/effort), so we don't actually want to hide it.
Could even be considered a "bugfix" for 4.4.2...