DAOS-19036 vos: store MBS information when allocate active DTX entry#18400
Closed
Nasf-Fan wants to merge 1 commit into
Closed
DAOS-19036 vos: store MBS information when allocate active DTX entry#18400Nasf-Fan wants to merge 1 commit into
Nasf-Fan wants to merge 1 commit into
Conversation
|
Ticket title is 'Argonne Daos_user : Engine ranks 590, 593, and 596 entered Errored state unexpectedly' |
Collaborator
|
Test stage Build on EL 9 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-18400/1/execution/node/272/log |
Nasf-Fan
force-pushed
the
Nasf-Fan/DAOS-19036
branch
from
d71cfd3 to
77d248e
Compare
Originally, the MBS (membership) information for an active DTX entry is stored when such DTX is ready (prepared) locally. But if there is CPU yield after DTX entry allocation but before it is prepared, then someone may find such DTX entry but with empty MBS information, that will trigger server side segmentation fault or misguide related user to take wrong action. This patch stores the MBS information when allocate related DTX entry. The patch also explicitly cleanup non-prepared DTX after modification failure to avoid leaving stale active DTX entry. Signed-off-by: Fan Yong <fan.yong@hpe.com>
Nasf-Fan
force-pushed
the
Nasf-Fan/DAOS-19036
branch
from
77d248e to
01a237e
Compare
Contributor
Author
|
Replaced by #18428 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally, the MBS (membership) information for an active DTX entry is stored when such DTX is ready (prepared) locally. But if there is CPU yield after DTX entry allocation but before it is prepared, then someone may find such DTX entry but with empty MBS information, that will trigger server side segmentation fault or misguide related user to take wrong action.
This patch stores the MBS information when allocate related DTX entry.
The patch also explicitly cleanup non-prepared DTX after modification failure to avoid leaving stale active DTX entry.
Steps for the author:
After all prior steps are complete: