Skip to content

Fix #14539: false positive: constParameterPointer with type alias #8310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ludviggunne wants to merge 2 commits into
base: main
Choose a base branch
from
+22 −1
Open

Fix #14539: false positive: constParameterPointer with type alias #8310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d84ccf4
Add test
ludviggunne Mar 8, 2026
a409730
Fix #14539
ludviggunne Mar 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/checkother.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2024,7 +2024,7 @@ void CheckOther::checkConstPointer()
// continue;
if (!isConstPointerVariable(p, *mSettings))
continue;
if (p->typeStartToken() && p->typeStartToken()->isSimplifiedTypedef() && !(Token::simpleMatch(p->typeEndToken(), "*") && !p->typeEndToken()->isSimplifiedTypedef()))
if (p->typeStartToken() && p->typeStartToken()->isSimplifiedTypedefOrUsing() && !(Token::simpleMatch(p->typeEndToken(), "*") && !p->typeEndToken()->isSimplifiedTypedefOrUsing()))
continue;
constVariableError(p, p->isArgument() ? p->scope()->function : nullptr);
}
Expand Down
12 changes: 12 additions & 0 deletions lib/token.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -655,6 +655,17 @@ class CPPCHECKLIB Token {
setFlag(fIsSimplifiedTypedef, b);
}

bool isSimplifiedUsing() const {
return getFlag(fIsSimplifiedUsing);
}
void isSimplifiedUsing(bool b) {
setFlag(fIsSimplifiedUsing, b);
}

bool isSimplifiedTypedefOrUsing() const {
return isSimplifiedTypedef() || isSimplifiedUsing();
}

bool isIncompleteConstant() const {
return getFlag(fIsIncompleteConstant);
}
Expand Down Expand Up @@ -1509,6 +1520,7 @@ class CPPCHECKLIB Token {
fIsInitComma = (1ULL << 43), // Is this comma located inside some {..}. i.e: {1,2,3,4}
fIsInitBracket = (1ULL << 44), // Is this bracket used as a part of variable initialization i.e: int a{5}, b(2);
fIsAnonymous = (1ULL << 45), // Is this a token added for an unnamed member
fIsSimplifiedUsing = (1ULL << 46),
Copy link
Collaborator

@chrchr-github chrchr-github Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simplifyUsing() already sets fIsSimplifiedTypedef, see e.g. here:

cppcheck/lib/tokenize.cpp

Line 3417 in 13f7e53

tok1->isSimplifiedTypedef(true);

So we should either use only the existing flag, or use the new one everywhere.

Copy link
Collaborator Author

@ludviggunne ludviggunne Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, that's strange, then we shouldn't have a false positive in the first place. I'll look in to it. Thanks!

};

enum : std::uint8_t {
Expand Down
3 changes: 3 additions & 0 deletions lib/tokenize.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2998,6 +2998,9 @@ bool Tokenizer::simplifyUsing()
if (!usingEnd)
continue;

for (Token *typeTok = start; typeTok != usingEnd; typeTok = typeTok->next())
typeTok->isSimplifiedUsing(true);

// Move struct defined in using out of using.
// using T = struct t { }; => struct t { }; using T = struct t;
// fixme: this doesn't handle attributes
Expand Down
6 changes: 6 additions & 0 deletions test/testother.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4763,6 +4763,12 @@ class TestOther : public TestFixture {
" return [](int* p) { return *p; }(&i);\n"
"}\n");
ASSERT_EQUALS("[test.cpp:3:20]: (style) Parameter 'p' can be declared as pointer to const [constParameterPointer]\n", errout_str());

check("using IntPtr = int *;\n"
"int* foo(IntPtr bar) {\n"
" return bar = 0;\n"
"}\n");
ASSERT_EQUALS("", errout_str());
}

void constArray() {
Expand Down
Loading