feat(voice-server): Add Linux support for v3.0 VoiceServer#686
Open
fayerman-source wants to merge 1 commit intodanielmiessler:mainfrom
Open
feat(voice-server): Add Linux support for v3.0 VoiceServer#686fayerman-source wants to merge 1 commit intodanielmiessler:mainfrom
fayerman-source wants to merge 1 commit intodanielmiessler:mainfrom
Conversation
Collaborator
|
Great work on this! We'd love to merge it, but it has merge conflicts with recent VoiceServer changes (error propagation fix in commit 95d65cc). Could you rebase on main and resolve the conflicts? Once rebased, we'll merge right away. Thanks! 🙏 |
server.ts: Cross-platform audio playback (afplay on macOS, mpg123/mpv on Linux with auto-detection) and desktop notifications (osascript on macOS, notify-send on Linux). Platform detected once at startup via os.platform(). install.sh: Detect macOS vs Linux, create LaunchAgent or systemd user service accordingly. Linux install checks for audio player and notify-send prerequisites. Logs go to ~/.config/pai/ on Linux. Closes danielmiessler#685
fayerman-source
force-pushed
the
feat/linux-compat-v3
branch
from
b03375e to
92c2b7f
Compare
Contributor
Author
|
Done! Rebased on main and resolved the conflict in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds cross-platform support to the v3.0 VoiceServer so it works on both macOS and Linux:
mpg123/mpv/aplayon Linux; preservesafplayon macOSnotify-sendon Linux; preservesosascripton macOSPlatform is detected once at startup — zero runtime overhead.
Files Changed
Releases/v3.0/.claude/VoiceServer/server.ts— Cross-platformplayAudio()andsendNotification()Releases/v3.0/.claude/VoiceServer/install.sh— Platform-aware service installation (LaunchAgent or systemd)Context
These are the same Linux fixes from PR #285 and PR #288 (both merged into the old
Packs/structure), ported to the v3.0 architecture. The original code was lost whenPacks/was removed during restructuring.PLATFORM.mdat the repo root documents Linux as "Fully Supported" and references these fixes — this PR makes that documentation accurate again for v3.0.Testing
Closes #685