Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request adds support for psycopg3 as a PostgreSQL driver alongside the existing asyncpg, psqlpy, and aiopg drivers. The implementation includes a complete broker, result backend, and schedule source for psycopg3, along with comprehensive integration tests.
Key Changes:
- Implementation of PsycopgBroker, PsycopgResultBackend, and PsycopgScheduleSource
- Refactored integration tests to use fixtures and reduce duplication
- Updated existing broker implementations to use private attributes for connections
- Added database cleanup fixtures for better test isolation
Reviewed Changes
Copilot reviewed 18 out of 19 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/taskiq_pg/psycopg/*.py | New psycopg3 implementation files (broker, result backend, schedule source, queries, init) |
| src/taskiq_pg/psqlpy/broker.py | Refactored to use private attributes and removed redundant null checks |
| src/taskiq_pg/psqlpy/schedule_source.py | Updated to use JSONB type wrapper for schedule data |
| src/taskiq_pg/asyncpg/broker.py | Refactored to use private attributes and added listener cleanup |
| tests/integration/test_broker.py | New consolidated broker tests with fixtures |
| tests/integration/test_schedule_source.py | Refactored tests with fixtures and added psycopg support |
| tests/integration/test_result_backend.py | Added psycopg to parameterized tests |
| tests/integration/conftest.py | Added database cleanup and connection fixtures |
| pyproject.toml | Added psycopg dependency and sqlalchemy-utils for tests |
| docs/index.md, README.md | Updated documentation with psycopg examples |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
e8d7342 to
4767bf8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #17