feat: add schedule source for psqlpy and aiopg#18
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds schedule source functionality for PostgreSQL-based TaskIQ brokers, supporting both psqlpy and aiopg database adapters alongside the existing asyncpg implementation. The implementation allows for persistent storage and retrieval of scheduled tasks from PostgreSQL databases.
- Implements
PSQLPyScheduleSourceandAiopgScheduleSourceclasses with full CRUD operations for task schedules - Refactors existing
AsyncpgScheduleSourceto inherit from a new shared base classBasePostgresScheduleSource - Adds comprehensive integration tests covering all three database adapters
Reviewed Changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/integration/test_schedule_source.py | Integration tests for all three schedule source implementations |
| src/taskiq_pg/psqlpy/schedule_source.py | PSQLPy-based schedule source implementation |
| src/taskiq_pg/psqlpy/queries.py | SQL queries for PSQLPy schedule operations |
| src/taskiq_pg/psqlpy/init.py | Export PSQLPyScheduleSource in public API |
| src/taskiq_pg/asyncpg/schedule_source.py | Refactored to use shared base class |
| src/taskiq_pg/aiopg/schedule_source.py | Aiopg-based schedule source implementation |
| src/taskiq_pg/aiopg/queries.py | SQL queries for aiopg schedule operations |
| src/taskiq_pg/aiopg/init.py | Export AiopgScheduleSource in public API |
| src/taskiq_pg/_internal/schedule_source.py | Shared base class for PostgreSQL schedule sources |
| src/taskiq_pg/_internal/init.py | Export shared base class |
| pyproject.toml | Linting configuration updates |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
f5a7c49 to
fc3c45e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #16 and #15