feat: same interface for all brokers/result backends#10
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements a unified interface for all PostgreSQL brokers and result backends by creating base classes that provide common functionality. The changes consolidate shared code patterns across different PostgreSQL driver implementations while maintaining compatibility with asyncpg, psqlpy, and aiopg drivers.
Key changes:
- Created base classes
BasePostgresBrokerandBasePostgresResultBackendto standardize interfaces - Refactored existing broker and result backend implementations to inherit from base classes
- Updated project configuration and dependencies for better development workflow
- Added comprehensive integration tests and documentation setup
Reviewed Changes
Copilot reviewed 23 out of 28 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
src/taskiq_pg/_internal/broker.py |
New base broker class with common PostgreSQL broker functionality |
src/taskiq_pg/_internal/result_backend.py |
New base result backend class with shared result storage logic |
src/taskiq_pg/asyncpg/broker.py |
Refactored to inherit from base broker class |
src/taskiq_pg/asyncpg/result_backend.py |
Refactored to inherit from base result backend class |
src/taskiq_pg/psqlpy/broker.py |
Refactored to inherit from base broker class |
src/taskiq_pg/psqlpy/result_backend.py |
Refactored to inherit from base result backend class |
src/taskiq_pg/aiopg/result_backend.py |
Refactored to inherit from base result backend class |
tests/integration/test_result_backend.py |
New integration tests for all result backend implementations |
pyproject.toml |
Updated project configuration, dependencies, and build system |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #8