Update spike time calculations for scattered non-spiking units#1871
Update spike time calculations for scattered non-spiking units#1871CodyCBakerPhD wants to merge 6 commits into
Conversation
…ther non-spiking units Fix bug in spike time handling by using unique indices.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1871 +/- ##
==========================================
+ Coverage 52.94% 52.95% +0.01%
==========================================
Files 87 87
Lines 12788 12787 -1
==========================================
+ Hits 6770 6771 +1
+ Misses 6018 6016 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@copilot Please add one new test for this case (of having multiple non-spiking units scattered throughout the rows of a untis table) |
Removed unused imports for metadata extraction.
Removed unnecessary import statements for get_metadata in multiple test cases.
Remove unnecessary blank line before assertions.
Added in commit |
Update session duration spike-time boundary handling to correctly support multiple non-spiking units scattered throughout a Units table, not just when the first unit is non-spiking.
The implementation now keeps only unit boundaries where cumulative spike count increases, which avoids invalid indexing from repeated boundaries contributed by non-spiking rows while preserving correct min/max spike-time extraction.
Also adds a regression test covering interleaved spiking and non-spiking unit rows to validate the expected session duration behavior.