Remember my spot: persist scroll position and filter tab selection #3396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces anchor-based scroll position tracking that stores event IDs rather than pixel offsets. This approach handles timeline updates gracefully - when new posts appear above, the user still returns to the same content they were viewing. Key design decisions: - Uses UserDefaults for simplicity (positions are ~100 bytes each) - Positions auto-expire after 24 hours to prevent stale state - Codable for easy serialization Part of damus-io#3393 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> Signed-off-by: alltheseas
Adds scrollPositions property to DamusState so all views can access the shared scroll position manager. Updates all initialization sites: - DamusState.swift (main init + convenience init + empty state) - ContentView.swift (app startup) - TestData.swift (test fixtures) - MockDamusState.swift (test mocks) Part of damus-io#3393 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> Signed-off-by: alltheseas
Implements the core scroll position save/restore mechanism: InnerTimelineView: - Adds onEventVisible/onEventHidden callbacks - Reports when events enter/exit the viewport via onAppear/onDisappear TimelineView: - Tracks visible event IDs in a Set - Adds optional positionKey parameter for enabling persistence - saveScrollPosition(): finds topmost visible event, saves to manager - restoreScrollPosition(): scrolls to saved event on view appear - Clears saved position when user taps "scroll to top" The anchor-based approach (saving event IDs vs pixel offsets) handles timeline updates gracefully - new posts above don't affect restoration. Part of damus-io#3393 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> Signed-off-by: alltheseas
Passes positionKey to TimelineView in: - PostingTimelineView: uses .homeTimeline key - SearchHomeView: uses .search key This enables automatic save/restore of scroll positions when users switch between these tabs or background the app. Part of damus-io#3393 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> Signed-off-by: alltheseas
Reset hasRestoredPosition flag on disappear so position is restored when returning from a thread/profile view. Without this fix, the flag would remain true and block restoration on subsequent view appearances. Closes damus-io#3393 Closes damus-io#3395 Closes damus-io#2137 Closes damus-io#2136 Closes damus-io#1720 Closes damus-io#1500 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> Signed-off-by: alltheseas
Change @SceneStorage to @AppStorage for filter_state so the user's selection (Posts vs Posts & Replies) survives killing and reopening the app. @SceneStorage only persists across scene sessions, not app termination. @AppStorage uses UserDefaults which persists across full app restarts. Closes damus-io#726 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> Signed-off-by: alltheseas
danieldaquino
added
the
pr-in-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds scroll position persistence so users return to their spot after switching tabs, backgrounding the app, or navigating into threads/profiles. Also persists the "Posts" vs "Posts & Replies" filter selection across app termination.
Scroll Position Persistence:
Filter Tab Persistence:
@SceneStorageto@AppStorageso selection survives app terminationChecklist
Standard PR Checklist
Closes:orFixes:tags in the commit messages wherever applicable, or made sure those are not needed. See Submitting patchesTest report
Device: Physical iOS device (Xcode compiled)
iOS: Latest
Damus: Commit 5d76ffa (remember-my-spot branch)
Setup: Standard Damus app with logged-in account
Steps:
Results:
All expected positions are saved and restored correctly.
Closes
Other notes
🤖 Generated with Claude Code