-
Notifications
You must be signed in to change notification settings - Fork 113
fix(ENG-456): delay recruiter rejection email by 30 mins and add send_date #3495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ENG-456): delay recruiter rejection email by 30 mins and add send_date #3495
Conversation
…_date - Added 30 minute delay using Customer.io send_at parameter - Added send_date to message_data for email template display - Email will now be scheduled 30 mins after rejection instead of immediate send
|
Chris seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
🍹 The Update (preview) for dailydotdev/api/prod (at 8acf355) was successful. Resource Changes Name Type Operation
~ vpc-native-update-views-cron kubernetes:batch/v1:CronJob update
~ vpc-native-user-profile-updated-sync-cron kubernetes:batch/v1:CronJob update
~ vpc-native-update-tags-str-cron kubernetes:batch/v1:CronJob update
~ vpc-native-clean-zombie-user-companies-cron kubernetes:batch/v1:CronJob update
~ vpc-native-bg-deployment kubernetes:apps/v1:Deployment update
~ vpc-native-update-highlighted-views-cron kubernetes:batch/v1:CronJob update
~ vpc-native-personalized-digest-cron kubernetes:batch/v1:CronJob update
~ vpc-native-ws-deployment kubernetes:apps/v1:Deployment update
~ vpc-native-clean-zombie-images-cron kubernetes:batch/v1:CronJob update
~ vpc-native-clean-stale-user-transactions-cron kubernetes:batch/v1:CronJob update
~ vpc-native-calculate-top-readers-cron kubernetes:batch/v1:CronJob update
~ vpc-native-expire-super-agent-trial-cron kubernetes:batch/v1:CronJob update
~ vpc-native-generate-search-invites-cron kubernetes:batch/v1:CronJob update
~ vpc-native-sync-subscription-with-cio-cron kubernetes:batch/v1:CronJob update
~ vpc-native-user-profile-analytics-clickhouse-cron kubernetes:batch/v1:CronJob update
~ vpc-native-update-tag-recommendations-cron kubernetes:batch/v1:CronJob update
~ vpc-native-clean-zombie-users-cron kubernetes:batch/v1:CronJob update
~ vpc-native-update-source-public-threshold-cron kubernetes:batch/v1:CronJob update
~ vpc-native-daily-digest-cron kubernetes:batch/v1:CronJob update
~ vpc-native-check-analytics-report-cron kubernetes:batch/v1:CronJob update
~ vpc-native-post-analytics-history-day-clickhouse-cron kubernetes:batch/v1:CronJob update
~ vpc-native-clean-zombie-opportunities-cron kubernetes:batch/v1:CronJob update
~ vpc-native-validate-active-users-cron kubernetes:batch/v1:CronJob update
~ vpc-native-clean-gifted-plus-cron kubernetes:batch/v1:CronJob update
~ vpc-native-hourly-notification-cron kubernetes:batch/v1:CronJob update
~ vpc-native-generic-referral-reminder-cron kubernetes:batch/v1:CronJob update
~ vpc-native-update-source-tag-view-cron kubernetes:batch/v1:CronJob update
~ vpc-native-personalized-digest-deployment kubernetes:apps/v1:Deployment update
- vpc-native-api-db-migration-2e86c12a kubernetes:batch/v1:Job delete
~ vpc-native-user-profile-analytics-history-clickhouse-cron kubernetes:batch/v1:CronJob update
~ vpc-native-update-trending-cron kubernetes:batch/v1:CronJob update
~ vpc-native-update-current-streak-cron kubernetes:batch/v1:CronJob update
+ vpc-native-api-db-migration-1cd3c5eb kubernetes:batch/v1:Job create
- vpc-native-api-clickhouse-migration-2e86c12a kubernetes:batch/v1:Job delete
+ vpc-native-api-clickhouse-migration-1cd3c5eb kubernetes:batch/v1:Job create
~ vpc-native-post-analytics-clickhouse-cron kubernetes:batch/v1:CronJob update
~ vpc-native-deployment kubernetes:apps/v1:Deployment update
~ vpc-native-temporal-deployment kubernetes:apps/v1:Deployment update
~ vpc-native-private-deployment kubernetes:apps/v1:Deployment update
|
rebelchris
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@claude please fix my comment
| import { isSubscribedToNotificationType } from './notifications/utils'; | ||
| import { NotificationChannel, NotificationType } from '../notifications/common'; | ||
|
|
||
| const REJECTION_EMAIL_DELAY_MS = 30 * 60 * 1000; // 30 minutes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already have a THIRTY_MINUTES const in query.ts
|
Claude finished @rebelchris's task in 1m 3s —— View job Completed
I've updated the worker file to use the The updated line now reads: const REJECTION_EMAIL_DELAY_MS = 30 * ONE_MINUTE_IN_SECONDS * 1000;Changes have been committed and pushed to the PR branch. --- | Branch |
Co-authored-by: Chris Bongers <rebelchris@users.noreply.github.com>
Summary
Adjusts recruiter rejection email timing and messaging per ENG-456.
Changes
send_atparameter)send_datetomessage_dataso the email template can display when the email was sentTemplate Note
The
send_datevariable is now available in Customer.io email template ID 88. Use{{send_date}}in the template to display the formatted date (e.g., "Jan 26, 2026").Testing
send_dateappears correctly in email template