audit: phase 2 verification U06-U10 (round 01)#520
Closed
samtrion wants to merge 1 commit into
Closed
Conversation
Independently verify usability assumptions U06–U10 from
audit/assumptions/round-01-usability.md. Each is CONFIRMED with fresh
file:line evidence and a failing test (or build-time repro) that Phase 3
builders can flip green.
U06 — OutboxProcessorOptionsDefaultsTests: assert desirable defaults
(backoff=true, batching=true, retry>=5). All three fail today.
U07 — AzureServiceBusReadmeQuickStartTests: building the ASB README quick
start verbatim must yield an actionable DI error and register
OutboxProcessorHostedService. Both assertions fail today.
U08 — SqlServerOutboxScriptPackagingTests + audit/repros/u08/repro.ps1:
OutboxMessage.sql is packed only under content\Scripts\ (legacy
packages.config), unreachable from PackageReference consumers.
U09 — MapStreamQueryJsonCasingTests: MapQuery honors ConfigureHttpJsonOptions
(camelCase) but MapStreamQuery uses raw JsonSerializer.Serialize and
emits PascalCase, breaking response consistency.
U10 — KafkaMessageTransportCancellationTests: SendBatchAsync calls
_producer.Flush(Timeout.InfiniteTimeSpan) and ignores its token,
so a stuck broker leaks the processor thread past ProcessingTimeout.
dotnet build of both Tests.Unit and Tests.Integration projects passes
with 0 errors / 0 warnings on net8.0;net9.0;net10.0.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 2 verification of usability assumptions U06–U10 from
audit/assumptions/round-01-usability.md. Each was independently re-readin this worktree, decided, and (when CONFIRMED) accompanied by a failing
test or build-time repro that Phase 3 builders can flip green.
MaxRetryCount=3, backoff=false, batching=false)tests/NetEvolve.Pulse.Tests.Unit/Outbox/OutboxProcessorOptionsDefaultsTests.csUse*Transportdoes not enforceAddOutbox/ registerIOutboxRepositorytests/NetEvolve.Pulse.Tests.Unit/AzureServiceBus/AzureServiceBusReadmeQuickStartTests.csOutboxMessage.sqlpacked only under legacycontent\Scripts\(not reachable from PackageReference)audit/repros/u08/repro.ps1+tests/.../SqlServer/SqlServerOutboxScriptPackagingTests.csMapStreamQueryignores configuredJsonSerializerOptions(camelCase vs PascalCase)tests/NetEvolve.Pulse.Tests.Unit/AspNetCore/MapStreamQueryJsonCasingTests.csKafkaMessageTransport.SendBatchAsyncignoresCancellationToken(Flush(Timeout.InfiniteTimeSpan))tests/NetEvolve.Pulse.Tests.Unit/Kafka/KafkaMessageTransportCancellationTests.csTally: CONFIRMED 5 / REFUTED 0 / NEEDS-NUANCE 0.
Per-assumption verification docs at
audit/verification/round-01-U##.mdinclude fresh
file:lineevidence, reasoning, the failing test code,and follow-up notes for Phase 3 builders. No production code is
changed — this is verification-only.
Test plan
dotnet build tests/NetEvolve.Pulse.Tests.Unit/NetEvolve.Pulse.Tests.Unit.csproj— passes 0 errors / 0 warnings on net8.0;net9.0;net10.0.dotnet build tests/NetEvolve.Pulse.Tests.Integration/NetEvolve.Pulse.Tests.Integration.csproj— passes 0 errors / 0 warnings on net8.0;net9.0;net10.0.pwsh audit/repros/u08/repro.ps1exits non-zero today (script not reachable from PackageReference consumers).🤖 Generated with Claude Code