-
-
Notifications
You must be signed in to change notification settings - Fork 0
feat: Switched to Microsoft Testing Platform #943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughRefactoring centralizes .NET target framework definitions via new MSBuild properties in Directory.Build.props. Multiple project files now reference these properties instead of hard-coded framework values. Test project dependencies updated: Microsoft.NET.Test.Sdk removed from MSTest and XUnit projects, replaced with Microsoft.Extensions.DependencyModel in NUnit test projects. Editor config extended XML line length. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #943 +/- ##
=======================================
Coverage 83.54% 83.54%
=======================================
Files 84 84
Lines 231 231
Branches 17 17
=======================================
Hits 193 193
Misses 32 32
Partials 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/NetEvolve.Extensions.NUnit/NetEvolve.Extensions.NUnit.csproj (1)
1-1: BOM character detected at start of file.The AI summary indicates a hidden BOM or non-printable character at the beginning of this file. While UTF-8 BOM is acceptable for .csproj files per the editorconfig, verify this is intentional.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting
📒 Files selected for processing (13)
.editorconfigDirectory.Build.propsDirectory.Packages.propssrc/NetEvolve.Extensions.MSTest/NetEvolve.Extensions.MSTest.csprojsrc/NetEvolve.Extensions.NUnit/NetEvolve.Extensions.NUnit.csprojsrc/NetEvolve.Extensions.TUnit/NetEvolve.Extensions.TUnit.csprojsrc/NetEvolve.Extensions.XUnit.V3/NetEvolve.Extensions.XUnit.V3.csprojtests/NetEvolve.Extensions.MSTest.Tests.PublicApi/NetEvolve.Extensions.MSTest.Tests.PublicApi.csprojtests/NetEvolve.Extensions.MSTest.Tests.Unit/NetEvolve.Extensions.MSTest.Tests.Unit.csprojtests/NetEvolve.Extensions.NUnit.Tests.PublicApi/NetEvolve.Extensions.NUnit.Tests.PublicApi.csprojtests/NetEvolve.Extensions.NUnit.Tests.Unit/NetEvolve.Extensions.NUnit.Tests.Unit.csprojtests/NetEvolve.Extensions.XUnit.V3.Tests.PublicApi/NetEvolve.Extensions.XUnit.V3.Tests.PublicApi.csprojtests/NetEvolve.Extensions.XUnit.V3.Tests.Unit/NetEvolve.Extensions.XUnit.V3.Tests.Unit.csproj
💤 Files with no reviewable changes (4)
- tests/NetEvolve.Extensions.XUnit.V3.Tests.PublicApi/NetEvolve.Extensions.XUnit.V3.Tests.PublicApi.csproj
- tests/NetEvolve.Extensions.MSTest.Tests.PublicApi/NetEvolve.Extensions.MSTest.Tests.PublicApi.csproj
- tests/NetEvolve.Extensions.XUnit.V3.Tests.Unit/NetEvolve.Extensions.XUnit.V3.Tests.Unit.csproj
- tests/NetEvolve.Extensions.MSTest.Tests.Unit/NetEvolve.Extensions.MSTest.Tests.Unit.csproj
🔇 Additional comments (9)
.editorconfig (1)
47-47: LGTM! Reasonable adjustment for XML project files.The increased line length accommodates longer property references and package definitions in csproj files, which aligns with the centralized target framework approach in this PR.
tests/NetEvolve.Extensions.NUnit.Tests.PublicApi/NetEvolve.Extensions.NUnit.Tests.PublicApi.csproj (1)
10-10: Verify test execution after dependency change.Replacing
Microsoft.NET.Test.SdkwithMicrosoft.Extensions.DependencyModelaligns with the Microsoft Testing Platform migration. Ensure that test discovery and execution work correctly with the new dependency.tests/NetEvolve.Extensions.NUnit.Tests.Unit/NetEvolve.Extensions.NUnit.Tests.Unit.csproj (1)
9-9: Verify test execution after dependency change.Consistent with the Microsoft Testing Platform migration pattern. Ensure test discovery and execution function correctly with
Microsoft.Extensions.DependencyModelinstead ofMicrosoft.NET.Test.Sdk.src/NetEvolve.Extensions.TUnit/NetEvolve.Extensions.TUnit.csproj (1)
3-3: LGTM! Centralized target framework reference.The switch from hard-coded frameworks to
$(NetEvolve_ProjectTargetFrameworks)aligns with the PR's centralization strategy. Based on the context, this should expand to include netstandard2.0 and the LTS frameworks.src/NetEvolve.Extensions.XUnit.V3/NetEvolve.Extensions.XUnit.V3.csproj (1)
3-3: LGTM! Centralized target framework reference.Consistent with the project-wide strategy to centralize target framework definitions using
$(NetEvolve_ProjectTargetFrameworks).src/NetEvolve.Extensions.MSTest/NetEvolve.Extensions.MSTest.csproj (1)
3-3: Centralized property definition verified.The
NetEvolve_ProjectTargetFrameworksproperty is correctly defined in Directory.Build.props (line 18) with the framework list:netstandard2.0;net8.0;net9.0;net10.0. Usage is consistent across all extension projects.src/NetEvolve.Extensions.NUnit/NetEvolve.Extensions.NUnit.csproj (1)
3-3: Use of NetEvolve_LTSTargetFrameworks is intentional and appropriate.This NUnit library correctly uses
$(NetEvolve_LTSTargetFrameworks)(net8.0;net9.0;net10.0), which is the intended property for test-related projects. TheNetEvolve_ProjectTargetFrameworksincludes netstandard2.0 for broader library compatibility, whileNetEvolve_TestTargetFrameworksandNetEvolve_LTSTargetFrameworksboth target LTS versions only. The choice is consistent with the framework configuration strategy and appropriate for a test library.Directory.Packages.props (1)
17-17: Clarify the purpose of Microsoft.Extensions.DependencyModel in this change.Version 10.0.1 is the current latest release (Dec 9, 2025), so the version is correct. However,
Microsoft.Extensions.DependencyModelis a runtime library for reading dependency context (.deps.json), not a test runner or test host. It does not replaceMicrosoft.NET.Test.Sdk, which is required for test discovery and execution. If this package is being added, clarify whether it is needed for specific test logic (e.g., runtime dependency inspection) or if this is part of a broader testing platform migration strategy.Likely an incorrect or invalid review comment.
Directory.Build.props (1)
17-19: The centralized framework property approach is well-structured and maintainable. The inclusion ofnet10.0is correct — it's an LTS release officially supported through November 2028. The property composition using variable references enables effective centralized management across projects.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.