Helms Heading Indicator and Keyboard Turning Adjustment.

[JonathanILevi]

I think this new indicator for target heading in Helms is nice and helpful. I think it also makes the turning behavior more intuitive (I had a couple new players yesterday on Helms that didn't get it at first, I think this would have helped them. ...I could also just get better at explaining XD)

For the keyboard turn left and right keys: It always annoying how the ship keeps turning after letting go of the turn key. I don't think the current behavior is preferred, if it is, I think a new turn-by key should be added. I think the fix I did here is adequate and easy.

[oznogon]

Not a fan of the value being upside down around 180 when using a fixed radar or behind the ship on a rotating radar, especially when moving the indicator while using a touchscreen:

Use of the target reticule is also IMO unnecessary. On the Tactical screen, the same reticule is used for weapon targets, and this would seem to add some confusion, especially in busier situations.

[oznogon]

The keyboard changes seemed familiar: @Ownezx's #2389 and #2412, which stalled out.

EDIT: Same for the helms heading indicator, #2380 and #2390, which also added target bearing indicators and options toggles.

[JonathanILevi]

Hum, yeah. That was really just what was quick and easy. Anything would be nice though, even if it's just a line. As apparently I'm not the first to think so.

[JonathanILevi]

This is a simpler change, not having a heading number, just a simple long tick. I think a heading number would be good, but not sure how, and this is simpler...so harder to disagree with?

[oznogon]

I like that indicator quite a bit better, especially when paired with active waypoints since the line clearly connects the heading request to the waypoint's bearing. The heading number stays readable and above the touch contact area so hands/fingers don't obscure it.

I also like it a bit better than #2390. The line connects it to the heading interface better IMO than the red ship-like deltas. If this lands and #2450 for line-drawing enhancements also gets addressed, I'd come back to this and see if the line could be made to stand out a little more.

For me the only question is whether this approach to Helms turning by keyboard is better than #2412, or perhaps if that part of this PR should be split off into its own PR since it doesn't depend on the indicator implementation. Keyboard controls on Helms aren't something that I have much playing experience with, and #2412 also attempted to address deadzones (and the SP dependency for that did land in daid/SeriousProton#259).

[JonathanILevi]

I can separate out the turning adjustment, I only included it because I thought they were related and cumbersome to have a bunch of tiny pull requests.