Skip to content

Conversation

@MikeMcC399
Copy link
Collaborator

@MikeMcC399 MikeMcC399 commented Mar 10, 2025

Situation

  • React *.jsx files are not currently linted. With the exception of the two Stepper*.jsx files in examples/component-tests/src/components however, all other *.jsx source files are scaffolded by npm create vite and should not be linted since the content is externally provided.

Assessment

Change

For the .prettierignore file:

  • Add *.jsx as an exception
  • Allow examples/component-tests/src/components/*.jsx

Run the following to correct style of examples/component-tests/src/components/*.jsx files:

npx prettier **/*.jsx --write

Verification

On Ubuntu 24.04.2 LTS, Node.js 22.14.0 LTS

git clean -xfd
npm ci
npx prettier **/*.jsx --check

and confirm the response is:

Checking formatting...
All matched files use Prettier code style!

@MikeMcC399 MikeMcC399 self-assigned this Mar 10, 2025
@cypress-app-bot
Copy link

@MikeMcC399 MikeMcC399 marked this pull request as ready for review March 10, 2025 15:21
@jennifer-shehane jennifer-shehane merged commit 6bc6051 into cypress-io:master Mar 11, 2025
74 checks passed
@MikeMcC399 MikeMcC399 deleted the jsx-prettier-linting branch March 11, 2025 14:11
MikeMcC399 added a commit to MikeMcC399/github-action that referenced this pull request Mar 18, 2025
@github-actions
Copy link

🎉 This PR is included in version 6.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants