gha: harden#384
Open
cyphar wants to merge 1 commit into
Open
Conversation
cyphar
force-pushed
the
gha-hardening
branch
2 times, most recently
from
55b27ae to
ed66008
Compare
Given the recent slew of supply-chain attacks, it seems far more prudent to avoiding using actions that aren't strictly necessary. dtolnay/rust-toolchain has a few helpers but ultimately you can just use stock rustup directly in the modern GHA environment, and installing stuff with "cargo install" is preferable than magic actions. (The tag-name-argument actions are most concerning because they are more annoying to deal with when switching to commit-hash-pinned use lines.) Signed-off-by: Aleksa Sarai <aleksa@amutable.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given the recent slew of supply-chain attacks, it seems far more prudent to avoiding using actions that aren't strictly necessary and to apply a few other proactive hardenings.