-
-
Notifications
You must be signed in to change notification settings - Fork 31
Feature/column position #226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…getComment rather than use annotations
…ly driver supporting column positioning
…o define being positioned first or after another column
Contributor
Author
|
Feedback welcome. Once this gets finalized and merged, we can look at necessary changes for migration support. |
roxblnfk
reviewed
Jul 3, 2025
…s. Which are now only defined in MySQLColumn class.
…ly defined in MySQLColumn class.
Contributor
Author
|
Adjustments have been made based on feedback, should now be good to merge. |
roxblnfk
reviewed
Jul 9, 2025
roxblnfk
reviewed
Jul 9, 2025
…ed as this functionality is only relevant for migrations
roxblnfk
approved these changes
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for managing column position when altering a table and adding a column. Ticket #63 is what sparked interest for this feature.
🔍 What was changed
ColumnInterfacenow includes methodsisFirstandgetAfter.ColumnInterfacenow definesgetComment()explicitly rather than using annotations.AbstractColumnimplementsisFirstandgetAfter, as well as setter methodsfirst()andafter.AbstractColumnreturns sane values by default, leaving it up to driver implementations to store values.MySQLColumnstores values forfirst()andaftermethods. Being the only driver supporting this feature.🤔 Why?
📝 Checklist
📃 Documentation