Skip to content

Skip performance tests on Mac CI for now, since they're flaky there #3183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndreasArvidsson merged 2 commits into from
Feb 20, 2026
+7 −6
Merged

Skip performance tests on Mac CI for now, since they're flaky there #3183

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b750a91
Skip performance tests on Mac CI for now, since they're flaky there
AndreasArvidsson Feb 20, 2026
afb304c
Doc skip in before each
AndreasArvidsson Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions packages/cursorless-vscode-e2e/src/suite/performance.vscode.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,12 @@ suite(`Performance ${thresholds.join("/")} ms`, async function () {
// Before each test, print the test title. This is done so we have the test
// title before the test run time / duration.
this.beforeEach(function () {
// FIXME: This test is flaky on Mac CI, so we skip it there for now
if (isCI() && isMac()) {
this.skip();
return;
}

const title = this.currentTest!.title;
if (title !== previousTitle) {
console.log(` ${title}`);
Expand Down Expand Up @@ -261,13 +267,8 @@ function generateTestData(n: number): string {

function calculateMultiplier() {
// The GitHub test runner is generally slower than running tests locally, so
// we increase the thresholds in CI. We do this for all platforms, but
// especially for macOS since the GitHub test runner for macOS is particularly
// slow.
// we increase the thresholds in CI.
if (isCI()) {
if (isMac()) {
return 3;
}
return 2;
}
return 1;
Expand Down
Loading