Skip to content

Add additional variable scope facets #3162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndreasArvidsson merged 25 commits into from
Feb 7, 2026
+2,406 −1,125
Merged

Add additional variable scope facets #3162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
7a61d73
c/csharp
AndreasArvidsson Feb 7, 2026
17b98c9
go
AndreasArvidsson Feb 7, 2026
b0c7a2a
java
AndreasArvidsson Feb 7, 2026
8f88622
js/ts
AndreasArvidsson Feb 7, 2026
d84b38d
kotlin
AndreasArvidsson Feb 7, 2026
d88fab8
lua
AndreasArvidsson Feb 7, 2026
958912e
php and properties
AndreasArvidsson Feb 7, 2026
162092b
python
AndreasArvidsson Feb 7, 2026
d9c006c
rust
AndreasArvidsson Feb 7, 2026
8d58b92
scala
AndreasArvidsson Feb 7, 2026
7b1f419
talon
AndreasArvidsson Feb 7, 2026
6b78c49
lua
AndreasArvidsson Feb 7, 2026
840a943
type and value
AndreasArvidsson Feb 7, 2026
9354c5b
More work on variable removal ranges
AndreasArvidsson Feb 7, 2026
fdcb709
Updates scope facet in foe markdown
AndreasArvidsson Feb 7, 2026
5b5a340
Fix python
AndreasArvidsson Feb 7, 2026
fdfad53
javascript
AndreasArvidsson Feb 7, 2026
d6b4d27
More clean up
AndreasArvidsson Feb 7, 2026
b922c4e
js fix
AndreasArvidsson Feb 7, 2026
c1c03eb
added missing
AndreasArvidsson Feb 7, 2026
71a6e71
More fixes
AndreasArvidsson Feb 7, 2026
58d35a0
Restore typo
AndreasArvidsson Feb 7, 2026
584ba41
lower case
AndreasArvidsson Feb 7, 2026
b96f201
Update tests
AndreasArvidsson Feb 7, 2026
978a70f
Update name
AndreasArvidsson Feb 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions data/fixtures/recorded/languages/rust/chuckName.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ initialState:
active: {line: 0, character: 5}
marks: {}
finalState:
documentContents: "let mut: [i32; 3] = [0; 3];"
documentContents: "[0; 3];"
selections:
- anchor: {line: 0, character: 5}
active: {line: 0, character: 5}
- anchor: {line: 0, character: 0}
active: {line: 0, character: 0}
24 changes: 24 additions & 0 deletions data/fixtures/scopes/c/name/name.constant.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
const int foo = 0;
---

[Content] = 0:10-0:13
>---<
0| const int foo = 0;

[Removal] = 0:0-0:16
>----------------<
0| const int foo = 0;

[Leading delimiter] = 0:9-0:10
>-<
0| const int foo = 0;

[Trailing delimiter] = 0:13-0:14
>-<
0| const int foo = 0;

[Domain] = 0:0-0:18
>------------------<
0| const int foo = 0;

[Insertion delimiter] = " "
53 changes: 39 additions & 14 deletions data/fixtures/scopes/c/name/name.field.class.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,45 @@
struct { int foo; };
struct foo {
int bar;
};
---

[Content] = 0:13-0:16
>---<
0| struct { int foo; };
[#1 Content] = 0:7-0:10
>---<
0| struct foo {

[Removal] = 0:12-0:16
>----<
0| struct { int foo; };
[#1 Removal] = 0:7-0:11
>----<
0| struct foo {

[Leading delimiter] = 0:12-0:13
>-<
0| struct { int foo; };
[#1 Leading delimiter] = 0:6-0:7
>-<
0| struct foo {

[Domain] = 0:9-0:17
>--------<
0| struct { int foo; };
[#1 Trailing delimiter] = 0:10-0:11
>-<
0| struct foo {

[Insertion delimiter] = " "
[#1 Domain] = 0:0-2:2
>------------
0| struct foo {
1| int bar;
2| };
--<

[#1 Insertion delimiter] = " "


[#2 Content] = 1:8-1:11
>---<
1| int bar;

[#2 Removal] =
[#2 Domain] = 1:4-1:12
>--------<
1| int bar;

[#2 Leading delimiter] = 1:7-1:8
>-<
1| int bar;

[#2 Insertion delimiter] = " "
53 changes: 39 additions & 14 deletions data/fixtures/scopes/c/name/name.field.class2.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,45 @@
union { int foo; };
union foo {
int bar;
};
---

[Content] = 0:12-0:15
>---<
0| union { int foo; };
[#1 Content] = 0:6-0:9
>---<
0| union foo {

[Removal] = 0:11-0:15
>----<
0| union { int foo; };
[#1 Removal] = 0:6-0:10
>----<
0| union foo {

[Leading delimiter] = 0:11-0:12
>-<
0| union { int foo; };
[#1 Leading delimiter] = 0:5-0:6
>-<
0| union foo {

[Domain] = 0:8-0:16
>--------<
0| union { int foo; };
[#1 Trailing delimiter] = 0:9-0:10
>-<
0| union foo {

[Insertion delimiter] = " "
[#1 Domain] = 0:0-2:2
>-----------
0| union foo {
1| int bar;
2| };
--<

[#1 Insertion delimiter] = " "


[#2 Content] = 1:8-1:11
>---<
1| int bar;

[#2 Removal] =
[#2 Domain] = 1:4-1:12
>--------<
1| int bar;

[#2 Leading delimiter] = 1:7-1:8
>-<
1| int bar;

[#2 Insertion delimiter] = " "
24 changes: 8 additions & 16 deletions data/fixtures/scopes/c/name/name.field.enum.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,16 +37,12 @@ enum Foo {
>---<
1| bar = 0,

[#2 Removal] = 1:4-1:8
>----<
[#2 Removal] = 1:4-1:10
>------<
1| bar = 0,

[#2 Leading delimiter] = 1:0-1:4
>----<
1| bar = 0,

[#2 Trailing delimiter] = 1:7-1:8
>-<
[#2 Trailing delimiter] = 1:7-1:10
>---<
1| bar = 0,

[#2 Domain] = 1:4-1:11
Expand All @@ -60,16 +56,12 @@ enum Foo {
>---<
2| baz = 1,

[#3 Removal] = 2:4-2:8
>----<
2| baz = 1,

[#3 Leading delimiter] = 2:0-2:4
>----<
[#3 Removal] = 2:4-2:10
>------<
2| baz = 1,

[#3 Trailing delimiter] = 2:7-2:8
>-<
[#3 Trailing delimiter] = 2:7-2:10
>---<
2| baz = 1,

[#3 Domain] = 2:4-2:11
Expand Down
0 ...ixtures/scopes/c/name/name.variable.scope → ...es/c/name/name.variable.initialized.scope
View file
Open in desktop
File renamed without changes.
17 changes: 17 additions & 0 deletions data/fixtures/scopes/c/name/name.variable.uninitialized.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
int foo;
---

[Content] = 0:4-0:7
>---<
0| int foo;

[Removal] =
[Domain] = 0:0-0:8
>--------<
0| int foo;

[Leading delimiter] = 0:3-0:4
>-<
0| int foo;

[Insertion delimiter] = " "
10 changes: 10 additions & 0 deletions data/fixtures/scopes/c/statement/statement.constant.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
const int foo = 0;
---

[Content] =
[Removal] =
[Domain] = 0:0-0:18
>------------------<
0| const int foo = 0;

[Insertion delimiter] = "\n"
0 ...opes/c/statement/statement.variable.scope → ...ment/statement.variable.initialized.scope
View file
Open in desktop
File renamed without changes.
10 changes: 10 additions & 0 deletions data/fixtures/scopes/c/statement/statement.variable.uninitialized.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
int foo;
---

[Content] =
[Removal] =
[Domain] = 0:0-0:8
>--------<
0| int foo;

[Insertion delimiter] = "\n"
24 changes: 24 additions & 0 deletions data/fixtures/scopes/c/type/type.constant.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
const int foo = 0;
---

[Content] = 0:6-0:9
>---<
0| const int foo = 0;

[Removal] = 0:6-0:10
>----<
0| const int foo = 0;

[Leading delimiter] = 0:5-0:6
>-<
0| const int foo = 0;

[Trailing delimiter] = 0:9-0:10
>-<
0| const int foo = 0;

[Domain] = 0:0-0:18
>------------------<
0| const int foo = 0;

[Insertion delimiter] = " "
0 ...xtures/scopes/c/type/type.variable2.scope → ...es/c/type/type.variable.initialized.scope
View file
Open in desktop
File renamed without changes.
0 ...ixtures/scopes/c/type/type.variable.scope → .../c/type/type.variable.uninitialized.scope
View file
Open in desktop
File renamed without changes.
20 changes: 20 additions & 0 deletions data/fixtures/scopes/c/value/value.constant.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
const int foo = 0;
---

[Content] = 0:16-0:17
>-<
0| const int foo = 0;

[Removal] = 0:13-0:17
>----<
0| const int foo = 0;

[Leading delimiter] = 0:13-0:16
>---<
0| const int foo = 0;

[Domain] = 0:0-0:18
>------------------<
0| const int foo = 0;

[Insertion delimiter] = " "
21 changes: 7 additions & 14 deletions data/fixtures/scopes/cpp/name/name.field.class.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,35 +35,28 @@ class Foo {
>---<
1| int bar;

[#2 Removal] = 1:7-1:11
>----<
[#2 Removal] =
[#2 Domain] = 1:4-1:12
>--------<
1| int bar;

[#2 Leading delimiter] = 1:7-1:8
>-<
1| int bar;

[#2 Domain] = 1:4-1:12
>--------<
1| int bar;

[#2 Insertion delimiter] = " "


[#3 Content] = 2:8-2:11
>---<
2| int baz = 1;

[#3 Removal] = 2:8-2:12
>----<
[#3 Removal] = 2:4-2:14
>----------<
2| int baz = 1;

[#3 Leading delimiter] = 2:7-2:8
>-<
2| int baz = 1;

[#3 Trailing delimiter] = 2:11-2:12
>-<
[#3 Leading delimiter] = 2:8-2:11
>---<
2| int baz = 1;

[#3 Domain] = 2:4-2:16
Expand Down
24 changes: 8 additions & 16 deletions data/fixtures/scopes/cpp/name/name.field.enum.scope
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,16 +37,12 @@ enum class Foo {
>---<
1| bar = 0,

[#2 Removal] = 1:4-1:8
>----<
[#2 Removal] = 1:4-1:10
>------<
1| bar = 0,

[#2 Leading delimiter] = 1:0-1:4
>----<
1| bar = 0,

[#2 Trailing delimiter] = 1:7-1:8
>-<
[#2 Trailing delimiter] = 1:7-1:10
>---<
1| bar = 0,

[#2 Domain] = 1:4-1:11
Expand All @@ -60,16 +56,12 @@ enum class Foo {
>---<
2| baz = 1,

[#3 Removal] = 2:4-2:8
>----<
2| baz = 1,

[#3 Leading delimiter] = 2:0-2:4
>----<
[#3 Removal] = 2:4-2:10
>------<
2| baz = 1,

[#3 Trailing delimiter] = 2:7-2:8
>-<
[#3 Trailing delimiter] = 2:7-2:10
>---<
2| baz = 1,

[#3 Domain] = 2:4-2:11
Expand Down
Loading
Loading