Skip to content

fix(uber_search): prevent esc key hiding select options #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
melonunderground wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(uber_search): prevent esc key hiding select options #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
97b03ed
fix(uber_search): prevent esc key hiding select options
melonunderground Feb 17, 2026
6e78f87
fix(pane): pass alwaysOpen to pane for Esc handling
melonunderground Feb 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion javascript/uber_search.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
var outputContainer = options.outputContainer || new UberSearch.OutputContainer({selectCaret: options.selectCaret, ariaLabel: options.ariaLabel})
var resultsContainer = $('<div class="results_container"></div>')
var messages = $('<div class="messages"></div>')
var pane = new UberSearch.Pane()
var pane = new UberSearch.Pane({alwaysOpen: options.alwaysOpen})

var searchField = new UberSearch.SearchField({
placeholder: options.searchPlaceholder,
Expand Down
20 changes: 13 additions & 7 deletions javascript/uber_search/pane.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,14 @@
(function($) {
UberSearch.Pane = function() {
UberSearch.Pane = function(options) {
var eventsTriggered = {
shown: 'shown',
hidden: 'hidden'
}

options = $.extend({
alwaysOpen: false
}, options)

var context = this
var model = {}
var isOpen = false
Expand Down Expand Up @@ -35,12 +39,14 @@
})

// Close the pane when the user presses escape
$(document).on('keyup', function(event){
if (event.which == 27 && isOpen){
context.hide()
return false
}
})
if (!options.alwaysOpen) {
$(document).on('keyup', function(event){
if (event.which == 27 && isOpen){
context.hide()
return false
}
})
}


// HELPER FUNCTIONS
Expand Down