Skip to content

User status flags#436

Merged
rogelioLpz merged 2 commits intomainfrom
user-flags
Mar 6, 2026
Merged

User status flags#436
rogelioLpz merged 2 commits intomainfrom
user-flags

Conversation

@rogelioLpz
Copy link
Member

@rogelioLpz rogelioLpz commented Feb 6, 2026

Summary by CodeRabbit

  • New Features

    • Added four user status flags for managing inactive accounts, fraud marking, PLD blocking, and security mode.
  • Chores

    • Package version bumped to 2.1.17.
    • Updated validation dependency to cuenca-validations 2.1.26.

@rogelioLpz rogelioLpz requested a review from gmorales96 February 6, 2026 23:07
@rogelioLpz rogelioLpz self-assigned this Feb 6, 2026
@coderabbitai
Copy link

coderabbitai bot commented Feb 6, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 6a97163d-10ff-4631-875a-97e3a1a61c75

📥 Commits

Reviewing files that changed from the base of the PR and between dbde6c4 and a3d0a71.

📒 Files selected for processing (2)
  • cuenca/version.py
  • requirements.txt
🚧 Files skipped from review as they are similar to previous changes (1)
  • requirements.txt

Walkthrough

Four boolean fields were added to the User model: is_inactive, is_fraud, is_pld_blocked, and is_security_mode (all default False). The User.update signature was extended to accept these four optional flags and they are passed into UserUpdateRequest. The User JSON example/schema was updated to include the new keys. The package version was bumped to 2.1.17 and cuenca-validations in requirements was updated to 2.1.26.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • alexviquez
🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title 'User status flags' accurately summarizes the main changes, which add four new boolean status flags (is_inactive, is_fraud, is_pld_blocked, is_security_mode) to the User model.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch user-flags

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Feb 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (318496f) to head (a3d0a71).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #436   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           54        54           
  Lines         1194      1198    +4     
=========================================
+ Hits          1194      1198    +4     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
cuenca/resources/users.py 100.00% <100.00%> (ø)
cuenca/version.py 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 318496f...a3d0a71. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rogelioLpz rogelioLpz marked this pull request as ready for review March 6, 2026 17:24
@rogelioLpz rogelioLpz changed the title user flags User status flags Mar 6, 2026
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
cuenca/resources/users.py (1)

178-181: Add regression tests for None vs False semantics on update flags.

Given these are optional booleans, tests should explicitly cover omitted (None) and explicit False/True to prevent payload/behavior regressions.

Also applies to: 205-208


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 167327f5-e0d7-430f-8bee-fee91c855837

📥 Commits

Reviewing files that changed from the base of the PR and between 318496f and dbde6c4.

📒 Files selected for processing (3)
  • cuenca/resources/users.py
  • cuenca/version.py
  • requirements.txt

@rogelioLpz rogelioLpz merged commit b9e5b16 into main Mar 6, 2026
18 of 39 checks passed
@rogelioLpz rogelioLpz deleted the user-flags branch March 6, 2026 18:31
@coderabbitai coderabbitai bot mentioned this pull request Mar 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants