Skip to content

Add COOPDESARROLLO and Dep y Pag Dig #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gmorales96 merged 1 commit into from
Jan 9, 2026
Merged

Add COOPDESARROLLO and Dep y Pag Dig #186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions clabe/banks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,12 @@
'903': '90903',
'130': '40130',
'140': '40140',
'725': '90725',
'652': '90652',
'688': '90688',
'680': '90680',
'723': '90723',
'729': '90729',
'722': '90722',
'720': '90720',
'151': '40151',
Expand Down Expand Up @@ -140,10 +142,12 @@
'90903': 'CoDi Valida',
'40130': 'Compartamos',
'40140': 'Consubanco',
'90725': 'COOPDESARROLLO',
'90652': 'Credicapital',
'90688': 'Crediclub',
'90680': 'Cristobal Colon',
'90723': 'Cuenca',
'90729': 'Dep y Pag Dig',
Comment on lines +145 to +150
Copy link

@coderabbitai coderabbitai bot Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Keep BANK_NAMES “alphabetical by bank name” and update the “Downloaded 2022-10-18” note if it’s no longer accurate.

Proposed tweak (optional) to avoid stale provenance 
-# 2022-10-18
+# Updated: 2026-01-09 (added 90725, 90729)

Committable suggestion skipped: line range outside the PR's diff.

🤖 Prompt for AI Agents 
In @clabe/banks.py around lines 145 - 150, The BANK_NAMES mapping is not sorted
alphabetically by the bank name values and the provenance note "Downloaded
2022-10-18" may be stale; reorder the entries in BANK_NAMES so the dict is
sorted by the bank name strings (values) in ascending alphabetical order while
preserving correct code keys (e.g., entries like '90725': 'COOPDESARROLLO',
'90652': 'Credicapital', etc.), and update the provenance/comment timestamp to
the actual download date (or remove it) wherever the "Downloaded 2022-10-18"
note is defined.

'40151': 'Donde',
'90616': 'Finamex',
'90634': 'Fincomun',
Expand Down
2 changes: 1 addition & 1 deletion clabe/version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__version__ = '2.1.7'
__version__ = '2.1.8'
Loading