Skip to content

Changes after support for constant_values in Cubed pad #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tomwhite merged 1 commit into from
May 26, 2026
+1 −2
Merged

Changes after support for constant_values in Cubed pad #46

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions cubed_xarray/tests/test_xarray.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,6 @@ def test_transpose(self):
v = self.lazy_var
self.assertLazyAndIdentical(u.T, v.T)

@pytest.mark.xfail(reason="needs pad mode='constant_values' in cubed")
def test_shift(self):
u = self.eager_var
v = self.lazy_var
Expand Down Expand Up @@ -362,7 +361,7 @@ def test_groupby(self):
actual = v.groupby("x").mean(...)
self.assertLazyAndAllClose(expected, actual)

@pytest.mark.xfail(reason="needs pad mode='constant_values' in cubed")
@pytest.mark.xfail(reason="needs cubed.lib.stride_tricks.sliding_window_view")
def test_rolling(self):
u = self.eager_array
v = self.lazy_array
Expand Down
Loading