[fix] replace server.propagate_in_transaction by server.gtid_dbid_at_multi#416
Merged
Conversation
…multi deps/xredis-gtid/xredis/xredis_gtid_rs.c tests/unit/moduleapi/propagate-gtid.tcl runtest-moduleapi Case: module auto-wrapped RedisModule_Replicate maps to one GTID Issue: one module auto-wrapped MULTI/EXEC could be mis-mapped into multiple GTIDs and crash in gtidSeqAppend because server.propagate_in_transaction was cleared before queued propagate() drained. Fix: use server.gtid_dbid_at_multi for the GTID in-multi check, and add a propagate-test.simple guard test plus moduleapi runner coverage. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
warrick1016
force-pushed
the
fix/propagate
branch
from
ec79354 to
1871fca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.