Use issue argument to get the correct SHA for the status check#281
Open
dshatz wants to merge 1 commit intoctrf-io:mainfrom
Open
Use issue argument to get the correct SHA for the status check#281dshatz wants to merge 1 commit intoctrf-io:mainfrom
dshatz wants to merge 1 commit intoctrf-io:mainfrom
Conversation
dshatz
force-pushed
the
check-explicit-pr
branch
from
5a60b23 to
5480dca
Compare
dshatz
force-pushed
the
check-explicit-pr
branch
from
5480dca to
519f540
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My setup:
workflow_run, try to add status checks to the PR.Expected:
PR checks added to PR check section next to testing jobs.
Actual:
PR checks not added anywhere (or somewhere I can't see them).
Explanation:
When running from a
workflow_runtrigger,context.shapoints to something other than the original PR sha. Currently in the code issue parameter is not being used for status checks, so i use it to get the sha and pass it tocreateCheckRun.