Defer most ShocSimple coordinate detection to CFGrid2D#218
Closed
Defer most ShocSimple coordinate detection to CFGrid2D#218
Conversation
The lat/lon coordinate detection was a subset of the CFGrid2D detection logic, but was less good. Fixes #217
Contributor
Author
|
The commits for this pull request were accidentally merged as part of #219 |
mx-moth
added a commit
that referenced
this pull request
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The lat/lon coordinate detection was a subset of the CFGrid2D detection logic, but was less good. More recent outputs from the SHOC dataset post processing scripts contain enough metadata to be handled by the CFGrid2D convention without any help, but for now the ShocSimple convention is worth keeping around for older less compliant datasets.
Fixes #217