Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughRefactored the tooltip/help layout for the Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
frontend/src/components/AdminSettingsEmergencyAccess.vue (1)
55-72: Improve error tooltip accessibility linkage to the input.Please link the tooltip and input for screen readers (
aria-invalid,aria-describedby,role="alert"), and make the tooltip boxrelativeso the arrow is anchored to it predictably.Suggested patch
<div v-if="defaultRequiredEmergencyKeySharesLessThenTwoError || defaultRequiredEmergencyKeySharesToHighError instanceof FormValidationFailedError" + id="requiredKeySharesError" + role="alert" + aria-live="polite" class="absolute left-1/2 -translate-x-1/2 -top-2 transform -translate-y-full z-10" > - <div class="bg-red-50 border border-red-300 text-red-900 px-2 py-1 rounded shadow-sm text-sm hyphens-auto"> + <div class="relative bg-red-50 border border-red-300 text-red-900 px-2 py-1 rounded shadow-sm text-sm hyphens-auto"> {{ requiredKeySharesValidationText }} <!-- Arrow --> <div class="absolute bottom-0 left-1/2 transform translate-y-1/2 rotate-45 w-2 h-2 bg-red-50 border-r border-b border-red-300"></div> </div> </div> <input id="requiredKeyShares" v-model.number="requiredShares" type="number" min="2" max="255" :disabled="!enableEmergencyAccess" class="rounded-md border-gray-300 shadow-sm sm:text-sm focus:ring-primary focus:border-primary text-left w-full disabled:cursor-not-allowed disabled:bg-gray-200" :class="{ 'border-red-300 text-red-900 focus:ring-red-500 focus:border-red-500': defaultRequiredEmergencyKeySharesError || defaultRequiredEmergencyKeySharesToHighError instanceof FormValidationFailedError}" + :aria-invalid="!!(defaultRequiredEmergencyKeySharesLessThenTwoError || defaultRequiredEmergencyKeySharesToHighError)" + :aria-describedby="(defaultRequiredEmergencyKeySharesLessThenTwoError || defaultRequiredEmergencyKeySharesToHighError) ? 'requiredKeySharesError' : undefined" :aria-label="t('admin.emergencyAccess.requiredKeys.ariaLabel')" />🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@frontend/src/components/AdminSettingsEmergencyAccess.vue` around lines 55 - 72, Make the validation tooltip accessible by giving the tooltip a stable id and a relative container, adding role="alert" to it, and linking it to the input via aria-describedby and aria-invalid when any validation error is present: update the tooltip div (the element shown when defaultRequiredEmergencyKeySharesLessThenTwoError || defaultRequiredEmergencyKeySharesToHighError instanceof FormValidationFailedError) to include a unique id (e.g., requiredKeySharesErrorId), add the CSS positioning class relative to the tooltip container so the arrow anchors predictably, and add role="alert"; then update the input with id="requiredKeyShares" to set :aria-describedby="error ? 'requiredKeySharesErrorId' : null" and :aria-invalid="error" (where error is the existing expression checking defaultRequiredEmergencyKeyShares... and defaultRequiredEmergencyKeySharesToHighError instanceof FormValidationFailedError or defaultRequiredEmergencyKeySharesError), keeping the existing v-model.number="requiredShares" and class bindings unchanged and referencing the same boolean expressions (or a new computed like hasRequiredKeySharesError) to ensure screen readers are informed.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@frontend/src/components/AdminSettingsEmergencyAccess.vue`:
- Around line 55-72: Make the validation tooltip accessible by giving the
tooltip a stable id and a relative container, adding role="alert" to it, and
linking it to the input via aria-describedby and aria-invalid when any
validation error is present: update the tooltip div (the element shown when
defaultRequiredEmergencyKeySharesLessThenTwoError ||
defaultRequiredEmergencyKeySharesToHighError instanceof
FormValidationFailedError) to include a unique id (e.g.,
requiredKeySharesErrorId), add the CSS positioning class relative to the tooltip
container so the arrow anchors predictably, and add role="alert"; then update
the input with id="requiredKeyShares" to set :aria-describedby="error ?
'requiredKeySharesErrorId' : null" and :aria-invalid="error" (where error is the
existing expression checking defaultRequiredEmergencyKeyShares... and
defaultRequiredEmergencyKeySharesToHighError instanceof
FormValidationFailedError or defaultRequiredEmergencyKeySharesError), keeping
the existing v-model.number="requiredShares" and class bindings unchanged and
referencing the same boolean expressions (or a new computed like
hasRequiredKeySharesError) to ensure screen readers are informed.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: cdaa2913-a848-458f-89c4-06dc9ebff44e
📒 Files selected for processing (1)
frontend/src/components/AdminSettingsEmergencyAccess.vue
overheadhunter
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AdminSettingsEmergencyAccesswas rendered below the input instead of above itMultiUserSelectInputGroup):-translate-y-fullto position above, arrow inside the tooltip box pointing downwardBefore:
After:
