Add info about Secret Service on password-and-recovery-key#97
Add info about Secret Service on password-and-recovery-key#97purejava wants to merge 1 commit intocryptomator:developfrom
Conversation
WalkthroughThis is a documentation-only change that adds a new "Secret Service (Linux)" section to the password and recovery key documentation. The section clarifies that Secret Service uses KDE Wallet or GNOME keyring as underlying storage, serves as the successor to previous approaches, works for both desktop environments, and requires the wallet/keyring to be installed and running with a default wallet/keyring present. Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Possibly related PRs
Suggested labels
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
docs/desktop/password-and-recovery-key.md (1)
133-140: Refine grammar on line 139 for clarity.The phrasing "with the default wallet, respectively keyring present" is awkward and may confuse readers. Replace "respectively" with clearer phrasing to align with the pattern used in other keychain sections.
- Requires KDE Wallet or GNOME keyring to be installed and running on your Linux system, with the default wallet, respectively keyring present. + Requires KDE Wallet or GNOME keyring to be installed and running on your Linux system, with the default wallet or keyring present.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/desktop/password-and-recovery-key.md(1 hunks)
🔇 Additional comments (1)
docs/desktop/password-and-recovery-key.md (1)
133-140: Addition is well-structured and consistent with existing documentation.The new "Secret Service (Linux)" section follows the established format of other keychain entries, provides clear information about its purpose, and appropriately describes its relationship to KDE Wallet and GNOME Keyring. The content integrates naturally into the documentation flow.
|
As this PR updates the Cryptomator documentation, it can be merged, once the other PR was reviewed and merged, that adds the secret service keychain provider feature to Cryptomator. The latter was requested and is pending. |
Belongs to cryptomator/integrations-linux#125