Enhance freemium

[SailReal]

No description provided.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 64d792b7-bb47-411d-9e87-4bff778372a4

📥 Commits

Reviewing files that changed from the base of the PR and between 81443ef and 39da46c.

📒 Files selected for processing (1)

• presentation/src/main/java/org/cryptomator/presentation/ui/activity/BaseActivity.kt

---

Walkthrough

This PR removes deferred restore-outcome persistence and observer wiring, replacing it with immediate dialog display after restorePurchases. RestoreOutcome-to-DialogFragment mapping is simplified to a direct when-expression. Shared-preference getters/setters and the RestoreOutcomeDialogObserver were deleted. Subscription lifecycle callbacks were changed from "upgraded to lifetime" to "activated first time", the CancelSubscriptionReminderDialog and its layout were removed, and an inline cancel-subscription hint plus a typed activity helper were added. BaseActivity.showDialog now guards against illegal fragment commits.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

• Add freemium model with 30-day trial, Google Play IAP, and write-access gating #630: Introduces new restore-outcome handling path with CryptomatorApp.lastRestoreOutcome and consumeLastRestoreOutcome(), directly connected to this PR's removal of the old RestoreOutcomeDialogObserver and SharedPreferencesHandler.pendingRestoreOutcome persistence flow.

🚥 Pre-merge checks | ✅ 2 | ❌ 3

❌ Failed checks (1 warning, 2 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check	❓ Inconclusive	The title 'Enhance freemium' is vague and generic, using a non-descriptive term that doesn't convey meaningful information about the specific changes in the changeset.	Use a more descriptive title that summarizes the main change, such as 'Remove legacy restore outcome persistence and dialog flow' or 'Simplify license state callbacks and restore outcome handling'.
Description check	❓ Inconclusive	No description was provided by the author, making it impossible to assess whether it relates to the changeset.	Add a pull request description explaining the changes, such as the removal of RestoreOutcomeDialogObserver, changes to license callbacks, and the new in-place restore outcome display flow.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feature/enhance-freemium

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@presentation/src/main/java/org/cryptomator/presentation/ui/layout/LicenseContentViewBinder.kt`:
- Around line 97-107: The restore dialog is shown unconditionally which can
crash if the FragmentManager state is already saved; update
LicenseContentViewBinder.showRestoreOutcome to guard before calling
BaseActivity.showDialog by checking activity.supportFragmentManager.isStateSaved
(and return early if true) or delegate to a safe helper that checks
isStateSaved/isDestroyed/isFinishing; reference the method
LicenseContentViewBinder.showRestoreOutcome and BaseActivity.showDialog and
ensure you only call dialog.show(supportFragmentManager, ACTIVE_DIALOG) when
supportFragmentManager.isStateSaved is false.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 370ba23c-ab11-42a4-9d33-a62e60444acd

📥 Commits

Reviewing files that changed from the base of the PR and between 0af31a0 and 81443ef.

📒 Files selected for processing (11)

• presentation/src/main/java/org/cryptomator/presentation/CryptomatorApp.kt
• presentation/src/main/java/org/cryptomator/presentation/licensing/LicenseStateOrchestrator.kt
• presentation/src/main/java/org/cryptomator/presentation/service/RestoreOutcome.kt
• presentation/src/main/java/org/cryptomator/presentation/service/RestoreOutcomeDialogObserver.kt
• presentation/src/main/java/org/cryptomator/presentation/ui/activity/LicenseCheckActivity.kt
• presentation/src/main/java/org/cryptomator/presentation/ui/dialog/CancelSubscriptionReminderDialog.kt
• presentation/src/main/java/org/cryptomator/presentation/ui/fragment/WelcomeLicenseFragment.kt
• presentation/src/main/java/org/cryptomator/presentation/ui/layout/LicenseContentViewBinder.kt
• presentation/src/main/res/layout/dialog_cancel_subscription_reminder.xml
• presentation/src/main/res/values/strings.xml
• util/src/main/java/org/cryptomator/util/SharedPreferencesHandler.kt

💤 Files with no reviewable changes (7)

• presentation/src/main/res/layout/dialog_cancel_subscription_reminder.xml
• presentation/src/main/java/org/cryptomator/presentation/ui/dialog/CancelSubscriptionReminderDialog.kt
• presentation/src/main/java/org/cryptomator/presentation/licensing/LicenseStateOrchestrator.kt
• presentation/src/main/java/org/cryptomator/presentation/ui/activity/LicenseCheckActivity.kt
• presentation/src/main/java/org/cryptomator/presentation/service/RestoreOutcomeDialogObserver.kt
• presentation/src/main/java/org/cryptomator/presentation/CryptomatorApp.kt
• util/src/main/java/org/cryptomator/util/SharedPreferencesHandler.kt