Open
Conversation
added 15 commits
January 26, 2023 12:15
f: make Prettier
6aaefa7 to
61630a8
Compare
316d8ae to
e2ca7c3
Compare
added 6 commits
February 3, 2023 04:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is in preparation for a larger refactor to update to modern, cross-platform
asyncWebCrypto, Uint8Array, nobleSecp256k1, etc.getXyz()s)assertsafe-bufferassert(x, msg)toif (!x) { throw new Error(msg) }to satisfytscs style of nullish checking.I actually meant to PR this onto my own fork, but... I think it could serve well here too for a v3.
The individual commits are very atomic as to be easy to read and reason about.