feat(string-comments): add attachments support and delete attachment …#225
Merged
andrii-bodnar merged 2 commits intocrowdin:mainfrom Dec 1, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #225 +/- ##
==========================================
+ Coverage 99.35% 99.35% +0.01%
==========================================
Files 178 178
Lines 8216 8225 +9
Branches 185 185
==========================================
+ Hits 8162 8171 +9
Misses 39 39
Partials 15 15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds full support for attachments in string comments, following the latest Crowdin API updates.
Implemented Changes
Added support for the
attachmentsparameter inadd_string_commentAdded new
delete_string_comment_attachmentendpointUpdated the request payload to include attachments when creating comments
Added and updated unit tests to verify:
Verification
Notes