feat: Add support for acceptSourceChanges in string-based MergeBranch API#221
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new field acceptSourceChanges to the MergeBranchRequest TypedDict class, expanding the merge branch request parameters to support accepting source changes during branch merging operations.
- Added
acceptSourceChangesboolean field toMergeBranchRequesttyped dictionary
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| deleteAfterMerge: Optional[bool] | ||
| sourceBranchId: int | ||
| dryRun: Optional[bool] | ||
| acceptSourceChanges: bool |
There was a problem hiding this comment.
The acceptSourceChanges field should be typed as Optional[bool] to maintain consistency with other optional fields in the MergeBranchRequest class (deleteAfterMerge and dryRun). Unless this is a required field, making it optional would provide a more flexible API design.
| acceptSourceChanges: bool | |
| acceptSourceChanges: Optional[bool] |
There was a problem hiding this comment.
@vinayakkamatcodes please address the comment above so I can merge the PR
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #221 +/- ##
==========================================
+ Coverage 99.35% 99.35% +0.01%
==========================================
Files 178 178
Lines 8216 8217 +1
Branches 185 185
==========================================
+ Hits 8162 8163 +1
Misses 39 39
Partials 15 15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This PR adds the optional acceptSourceChanges parameter to the MergeBranchRequest TypedDict for the string-based API. Resolves #217