fix: add branchIds parameter to apply_pre_translation #212
Closed
FaizaJibril wants to merge 3 commits intocrowdin:mainfrom
Closed
fix: add branchIds parameter to apply_pre_translation #212FaizaJibril wants to merge 3 commits intocrowdin:mainfrom
branchIds parameter to apply_pre_translation #212FaizaJibril wants to merge 3 commits intocrowdin:mainfrom
Conversation
…lation - Added branchIds: Optional[Iterable[int]] = None parameter - Updated method signature and request data - Added comprehensive tests for the new parameter - Maintains backward compatibility - Resolves validation error when calling apply_pre_translation Closes crowdin#211
- Added test for branchIds parameter handling - Added edge case tests for empty lists and parameter combinations - Improved test coverage from 47% to 98% - Tests would have caught the missing branchIds bug
FaizaJibril
changed the title
andrii-bodnar
changed the title
branchIds parameter to apply_pre_translation
andrii-bodnar
changed the title
branchIds parameter to apply_pre_translation branchIds parameter to apply_pre_translation
Member
|
@FaizaJibril thank you for the contribution! The pipeline has failed, please take a look - https://github.com/crowdin/crowdin-api-client-python/actions/runs/17236411573/job/48908026609 |
- Fixed line length (E501) by breaking long import - Removed trailing whitespace (W293) - Fixed whitespace before parenthesis (E202) - All flake8 checks now pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added branchIds: Optional[Iterable[int]] = None parameter
Updated method signature and request data
Added tests for the new parameter
Resolved validation error when calling apply_pre_translation