Skip to content

Support grpc options #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iciclespider merged 4 commits into from
Nov 24, 2025
+7 −1
Merged

Support grpc options #188

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2abab1d
support grpc server options
P0t4T0o Nov 20, 2025
01f7a06
update
P0t4T0o Nov 20, 2025
6094cad
fix lint issues
P0t4T0o Nov 24, 2025
cf9611c
add example to docstring
P0t4T0o Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion crossplane/function/runtime.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@
import asyncio
import os
import signal
from collections.abc import Sequence
from typing import Any
Comment on lines +20 to +21
Copy link
Copy Markdown
Member

@negz negz Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We typically try to avoid importing types directly, but instead only import packages. I thought our linter should catch this. I'll update it.


import grpc
from grpc_reflection.v1alpha import reflection
Expand Down Expand Up @@ -73,6 +75,7 @@ def serve(
*,
creds: grpc.ServerCredentials,
insecure: bool,
options: Sequence[tuple[str, Any]] | None = None,
) -> None:
"""Start a gRPC server and serve requests asychronously.

Expand All @@ -81,6 +84,7 @@ def serve(
address: The address at which to listen for requests.
creds: The credentials used to authenticate requests.
insecure: Serve insecurely, without credentials or encryption.
options: Additional gRPC server options.
Copy link
Copy Markdown
Member

@ezgidemirel ezgidemirel Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: we can give some option examples


Raises:
ValueError if creds is None and insecure is False.
Expand All @@ -91,7 +95,7 @@ def serve(
# Define the loop before the server so everything uses the same loop.
loop = asyncio.get_event_loop()

server = grpc.aio.server()
server = grpc.aio.server(options=options)

loop.add_signal_handler(
signal.SIGTERM,
Expand Down