Fix Bedrock non-streaming thinking_tokens always returning nil#714
Open
alexmamrenko wants to merge 1 commit intocrmne:mainfrom
Open
Fix Bedrock non-streaming thinking_tokens always returning nil#714alexmamrenko wants to merge 1 commit intocrmne:mainfrom
alexmamrenko wants to merge 1 commit intocrmne:mainfrom
Conversation
Author
|
Failed rubocop is not related to my changes |
b8ff0db to
e7ab477
Compare
The Bedrock Converse API returns thinking token counts nested under usage.outputTokensDetails.reasoningTokens, not at the top-level usage.reasoningTokens. The streaming parser already handles this fallback correctly, but parse_completion_response only checked the top-level key. Add fallback to nested path and tests covering both paths.
e7ab477 to
9c943a3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
The Bedrock Converse API returns thinking/reasoning token counts nested under
usage.outputTokensDetails.reasoningTokens, not at the top-levelusage.reasoningTokens.The streaming parser already handles this correctly via
extract_reasoning_tokensinbedrock/streaming.rb:But
parse_completion_responseinbedrock/chat.rbonly checked the top-level key:This caused
thinking_tokensto always benilfor non-streaming Bedrock requests (e.g.chat.ask).The fix adds the nested key fallback to match the streaming parser's behavior:
Type of change
Scope check
Quality check
overcommit --installand all hooks passbundle exec rake vcr:record[provider_name]bundle exec rspecmodels.json,aliases.json)AI-generated code
API changes