Preserves assume_model_exists in to_llm for custom models#564
Merged
crmne merged 2 commits intocrmne:mainfrom Mar 1, 2026
Merged
Preserves assume_model_exists in to_llm for custom models#564crmne merged 2 commits intocrmne:mainfrom
crmne merged 2 commits intocrmne:mainfrom
Conversation
schoblaska
added a commit
to schoblaska/ruby_llm_test
that referenced
this pull request
Jan 12, 2026
|
Confirmed that this fix works on my test repo. Thanks, @creaumond ! |
Closed
3 tasks
|
Works for us also. Would love to see it merged in. |
crmne
approved these changes
Mar 1, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #564 +/- ##
=======================================
Coverage 80.88% 80.88%
=======================================
Files 113 113
Lines 5184 5184
Branches 1343 1343
=======================================
Hits 4193 4193
Misses 991 991 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
When a user passes in the
assume_model_existsflag through a custom Rails model, the flag gets dropped and they are not able to utilize a custom model.This persists that flag or sets it to false if not provided.
Type of change
Scope check
Quality check
overcommit --installand all hooks passbundle exec rake vcr:record[provider_name]bundle exec rspecmodels.json,aliases.json)API changes
Related issues
#555