Skip to content

Add provider wrapper unit specs#546

Closed
afurm wants to merge 4 commits intocrmne:mainfrom
afurm:add-provider-wrapper-specs
Closed

Add provider wrapper unit specs#546
afurm wants to merge 4 commits intocrmne:mainfrom
afurm:add-provider-wrapper-specs

Conversation

@afurm
Copy link
Copy Markdown
Contributor

@afurm afurm commented Dec 21, 2025

What this does

  • Adds unit specs for provider wrappers to verify api_base and auth headers for DeepSeek, Mistral, OpenRouter, Perplexity, Ollama, GPUStack, and VertexAI.
  • Covers Perplexity HTML auth error parsing and the VertexAI VCR test-token path.
  • Keeps coverage deterministic (no network / no VCR required).

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation
  • Performance improvement

Scope check

  • I read the Contributing Guide
  • This aligns with RubyLLM's focus on LLM communication
  • This isn't application-specific logic that belongs in user code
  • This benefits most users, not just my specific use case

Quality check

  • I ran overcommit --install and all hooks pass
  • I tested my changes thoroughly
    • For provider changes: Re-recorded VCR cassettes with bundle exec rake vcr:record[provider_name]
    • All tests pass: bundle exec rspec --tag ~generator (pre-commit hook)
  • I updated documentation if needed
  • I didn't modify auto-generated files manually (models.json, aliases.json)

API changes

  • Breaking change
  • New public methods/classes
  • Changed method signatures
  • No API changes

Related issues

@crmne
Copy link
Copy Markdown
Owner

crmne commented Mar 1, 2026

There's no need for those as we test on real APIs.

@crmne crmne closed this Mar 1, 2026
@afurm afurm deleted the add-provider-wrapper-specs branch March 1, 2026 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants