Fix CSP: Apply nonce attribute before appending the element #613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ndbroadbent is attempting to deploy a commit to the Cristian Bote's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
ndbroadbent
force-pushed
the
fix/further-csp-fix
branch
5 times, most recently
from
8b31e2d to
fad9fcb
Compare
…ment to the head. Added a test
ndbroadbent
force-pushed
the
fix/further-csp-fix
branch
from
fad9fcb to
9cda63c
Compare
Owner
|
Ah I see. No worries. Size Change: -13 B (0%) Total Size: 3.95 kB
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! Sorry I realized that I messed up the earlier attempt at CSP support. The nonce attribute has to be set BEFORE appending the element to the head, otherwise you still get CSP warnings about the style tag, even if it only contains a single space character or an empty string. After this change, the e2e test suite in my project runs 100% with no CSP errors.
I also added a test case, and was able to get the filesize limit back down to 1300B!
Thanks!