fix: skip signal handler registration in non-main thread #4290
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4289 - When CrewAI is initialized from a non-main thread (e.g., in Streamlit, Flask, Django, Jupyter), the telemetry module was printing multiple noisy
ValueErrortracebacks for each signal handler registration attempt.The fix adds a proactive main thread check in
_register_shutdown_handlers()before attempting signal registration. If not in the main thread, a debug message is logged and signal handler registration is skipped entirely, avoiding the noisy exception tracebacks.Changes:
threading.current_thread() is not threading.main_thread()Review & Testing Checklist for Human
logger.debug()is the appropriate log level (issue suggestedlogger.warning()with docs link, but debug is less noisy which aligns with the goal)Notes