Skip to content

Use fast parameter parsing API #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JakubOnderka wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use fast parameter parsing API #94

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 15 additions & 6 deletions php_simdjson.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,9 +123,13 @@ static zend_always_inline bool simdjson_validate_depth(zend_long depth, const ch
PHP_FUNCTION (simdjson_is_valid) {
zend_string *json = NULL;
zend_long depth = SIMDJSON_PARSE_DEFAULT_DEPTH;
if (zend_parse_parameters(ZEND_NUM_ARGS(), "S|l", &json, &depth) == FAILURE) {
RETURN_THROWS();
}

ZEND_PARSE_PARAMETERS_START(1, 2)
Z_PARAM_STR(json)
Z_PARAM_OPTIONAL
Z_PARAM_LONG(depth)
ZEND_PARSE_PARAMETERS_END();

if (!simdjson_validate_depth(depth, "simdjson_is_valid", 2)) {
RETURN_THROWS();
}
Expand All @@ -145,9 +149,14 @@ PHP_FUNCTION (simdjson_decode) {
zend_bool associative = 0;
zend_long depth = SIMDJSON_PARSE_DEFAULT_DEPTH;
zend_string *json = NULL;
if (zend_parse_parameters(ZEND_NUM_ARGS(), "S|bl", &json, &associative, &depth) == FAILURE) {
RETURN_THROWS();
}

ZEND_PARSE_PARAMETERS_START(1, 3)
Z_PARAM_STR(json)
Z_PARAM_OPTIONAL
Z_PARAM_BOOL(associative)
Z_PARAM_LONG(depth)
ZEND_PARSE_PARAMETERS_END();

if (!simdjson_validate_depth(depth, "simdjson_decode", 2)) {
RETURN_THROWS();
}
Expand Down