Skip to content

fix libkrb5 and decimal shard build#1107

Merged
henderkes merged 4 commits intomainfrom
feat/decimal
Apr 16, 2026
Merged

fix libkrb5 and decimal shard build#1107
henderkes merged 4 commits intomainfrom
feat/decimal

Conversation

@henderkes
Copy link
Copy Markdown
Collaborator

What does this PR do?

fixes zig-cc 0.16 being stricter. Silly of krb5 to define -Werror on it when they assign a const pointer to a non-const pointer type.

Checklist before merging

If your PR involves the changes mentioned below and completed the action, please tick the corresponding option.
If a modification is not involved, please skip it directly.

  • If you modified *.php or *.json, run them locally to ensure your changes are valid:
    • composer cs-fix
    • composer analyse
    • composer test
    • bin/spc dev:sort-config
  • If it's an extension or dependency update, please ensure the following:
    • Add your test combination to src/globals/test-extensions.php.
    • If adding new or fixing bugs, add commit message containing extension test or test extensions to trigger full test suite.

@henderkes henderkes requested a review from crazywhalecc April 16, 2026 06:47
Copy link
Copy Markdown
Owner

@crazywhalecc crazywhalecc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

``

@henderkes
Copy link
Copy Markdown
Collaborator Author

https://github.com/static-php/packages/actions/runs/24497908683/job/71597138154

waiting for this to pass before merging

@henderkes henderkes merged commit 9bcb809 into main Apr 16, 2026
8 checks passed
@henderkes
Copy link
Copy Markdown
Collaborator Author

Well those are fixed, but ext-intl segfaults on zig 0.16 with aarch64.

@henderkes henderkes deleted the feat/decimal branch April 16, 2026 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants