Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
surister
approved these changes
Dec 22, 2025
crate-2.0.0.post42+g1c30e65.d20251220.tar.gz crate-2.0.0.post42+g1c30e65.d20251220-py3-none-any.whl
>>> import crate.client >>> crate.client.__version__ '2.0.0.post43+g7ceffbb.d20251220'
mfussenegger
added a commit
that referenced
this pull request
Jan 19, 2026
- Removes buildout; test_layer now fetches the crate package itself - Removes setup.py - Removes stale bin/test - Removes stale requirements.txt - Updates DEVELOP.rst - Removes poethepoet. Most python developers are familiar with `ruff`, `mypy` and `pytest`, no need to add an extra DSL on top that obfuscates what's being used. - Removes `bootstrap.sh`. `python -m venv` or `uv venv` are trivial enough and Python developers should be familiar with them. - Removes the `devtools/create_tag.sh` script. It used `python setup.py --version` to get the new version, which since #757 was broken - running into a chicken and egg problem: Can't read the version from git to when about to create a new version tag. Must use `git tag -s <version>` instead. - Updates the release job, which used `python -m build`, which wasn't specified as dependency anywhere. `hatch` is now used which `uv build` will pickup.
mfussenegger
added a commit
that referenced
this pull request
Jan 19, 2026
- Removes buildout; test_layer now fetches the crate package itself - Removes setup.py - Removes stale bin/test - Removes stale requirements.txt - Updates DEVELOP.rst - Removes poethepoet. Most python developers are familiar with `ruff`, `mypy` and `pytest`, no need to add an extra DSL on top that obfuscates what's being used. - Removes `bootstrap.sh`. `python -m venv` or `uv venv` are trivial enough and Python developers should be familiar with them. - Removes the `devtools/create_tag.sh` script. It used `python setup.py --version` to get the new version, which since #757 was broken - running into a chicken and egg problem: Can't read the version from git to when about to create a new version tag. Must use `git tag -s <version>` instead. - Updates the release job, which used `python -m build`, which wasn't specified as dependency anywhere. `hatch` is now used which `uv build` will pickup.
mfussenegger
added a commit
that referenced
this pull request
Jan 19, 2026
- Removes buildout; test_layer now fetches the crate package itself - Removes setup.py - Removes stale bin/test - Removes stale requirements.txt - Updates DEVELOP.rst - Removes poethepoet. Most python developers are familiar with `ruff`, `mypy` and `pytest`, no need to add an extra DSL on top that obfuscates what's being used. - Removes `bootstrap.sh`. `python -m venv` or `uv venv` are trivial enough and Python developers should be familiar with them. - Removes the `devtools/create_tag.sh` script. It used `python setup.py --version` to get the new version, which since #757 was broken - running into a chicken and egg problem: Can't read the version from git to when about to create a new version tag. Must use `git tag -s <version>` instead. - Updates the release job, which used `python -m build`, which wasn't specified as dependency anywhere. `hatch` is now used which `uv build` will pickup.
mfussenegger
added a commit
that referenced
this pull request
Jan 19, 2026
- Removes buildout; test_layer now fetches the crate package itself - Removes setup.py - Removes stale bin/test - Removes stale requirements.txt - Updates DEVELOP.rst - Removes poethepoet. Most python developers are familiar with `ruff`, `mypy` and `pytest`, no need to add an extra DSL on top that obfuscates what's being used. - Removes `bootstrap.sh`. `python -m venv` or `uv venv` are trivial enough and Python developers should be familiar with them. - Removes the `devtools/create_tag.sh` script. It used `python setup.py --version` to get the new version, which since #757 was broken - running into a chicken and egg problem: Can't read the version from git to when about to create a new version tag. Must use `git tag -s <version>` instead. - Updates the release job, which used `python -m build`, which wasn't specified as dependency anywhere. `hatch` is now used which `uv build` will pickup.
Merged
mfussenegger
added a commit
that referenced
this pull request
Jan 19, 2026
- Removes buildout; test_layer now fetches the crate package itself - Removes setup.py - Removes stale bin/test - Removes stale requirements.txt - Updates DEVELOP.rst - Removes poethepoet. Most python developers are familiar with `ruff`, `mypy` and `pytest`, no need to add an extra DSL on top that obfuscates what's being used. - Removes `bootstrap.sh`. `python -m venv` or `uv venv` are trivial enough and Python developers should be familiar with them. - Removes the `devtools/create_tag.sh` script. It used `python setup.py --version` to get the new version, which since #757 was broken - running into a chicken and egg problem: Can't read the version from git when about to create a new version tag. Must use `git tag -s <version>` instead. - Updates the release job. It used `python -m build`, which wasn't specified as dependency anywhere. `hatch` is now used which `uv build` will pickup.
mfussenegger
added a commit
that referenced
this pull request
Jan 19, 2026
- Removes buildout; test_layer now fetches the crate package itself - Removes setup.py - Removes stale bin/test - Removes stale requirements.txt - Updates DEVELOP.rst - Removes poethepoet. Most python developers are familiar with `ruff`, `mypy` and `pytest`, no need to add an extra DSL on top that obfuscates what's being used. - Removes `bootstrap.sh`. `python -m venv` or `uv venv` are trivial enough and Python developers should be familiar with them. - Removes the `devtools/create_tag.sh` script. It used `python setup.py --version` to get the new version, which since #757 was broken - running into a chicken and egg problem: Can't read the version from git when about to create a new version tag. Must use `git tag -s <version>` instead. - Updates the release job. It used `python -m build`, which wasn't specified as dependency anywhere. `hatch` is now used which `uv build` will pickup.
mfussenegger
added a commit
that referenced
this pull request
Jan 19, 2026
- Removes buildout; test_layer now fetches the crate package itself - Removes setup.py - Removes stale bin/test - Removes stale requirements.txt - Updates DEVELOP.rst - Removes poethepoet. Most python developers are familiar with `ruff`, `mypy` and `pytest`, no need to add an extra DSL on top that obfuscates what's being used. - Removes `bootstrap.sh`. `python -m venv` or `uv venv` are trivial enough and Python developers should be familiar with them. - Removes the `devtools/create_tag.sh` script. It used `python setup.py --version` to get the new version, which since #757 was broken - running into a chicken and egg problem: Can't read the version from git when about to create a new version tag. Must use `git tag -s <version>` instead. - Updates the release job. It used `python -m build`, which wasn't specified as dependency anywhere. `hatch` is now used which `uv build` will pickup.
mfussenegger
added a commit
that referenced
this pull request
Jan 19, 2026
- Removes buildout; test_layer now fetches the crate package itself - Removes setup.py - Removes stale bin/test - Removes stale requirements.txt - Updates DEVELOP.rst - Removes poethepoet. Most python developers are familiar with `ruff`, `mypy` and `pytest`, no need to add an extra DSL on top that obfuscates what's being used. - Removes `bootstrap.sh`. `python -m venv` or `uv venv` are trivial enough and Python developers should be familiar with them. - Removes the `devtools/create_tag.sh` script. It used `python setup.py --version` to get the new version, which since #757 was broken - running into a chicken and egg problem: Can't read the version from git when about to create a new version tag. Must use `git tag -s <version>` instead. - Updates the release job. It used `python -m build`, which wasn't specified as dependency anywhere. `hatch` is now used which `uv build` will pickup.
mfussenegger
added a commit
that referenced
this pull request
Jan 19, 2026
- Removes buildout; test_layer now fetches the crate package itself - Removes setup.py - Removes stale bin/test - Removes stale requirements.txt - Updates DEVELOP.rst - Removes poethepoet. Most python developers are familiar with `ruff`, `mypy` and `pytest`, no need to add an extra DSL on top that obfuscates what's being used. - Removes `bootstrap.sh`. `python -m venv` or `uv venv` are trivial enough and Python developers should be familiar with them. - Removes the `devtools/create_tag.sh` script. It used `python setup.py --version` to get the new version, which since #757 was broken - running into a chicken and egg problem: Can't read the version from git when about to create a new version tag. Must use `git tag -s <version>` instead. - Updates the release job. It used `python -m build`, which wasn't specified as dependency anywhere. `hatch` is now used which `uv build` will pickup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About
Use versioningit like with other projects, to have more granular versioning, directly based on Git tags, so releasing no longer needs the version bumping step, among other goodies.
Details
The more granular versioning condensates on built artefacts, and the built-in module
__version__inquiry.