CODEBOX_ADMINS github usernames should be case-insensitive#93
Open
brimworks wants to merge 3 commits intocraftship:masterfrom
Open
CODEBOX_ADMINS github usernames should be case-insensitive#93brimworks wants to merge 3 commits intocraftship:masterfrom
brimworks wants to merge 3 commits intocraftship:masterfrom
Conversation
One of our admin users give me their github username, but the API returned their user-name with some capitol letters which made them appear as though they were not administrators.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of our admin users give me their github username, but the API returned their user-name with some capitol letters which made them appear as though they were not administrators.
What did you implement:
Closes #12345 (Github)
Github admin usernames should be case-insensitive.
How did you implement it:
Lower-case the usernames and then do indexOf() to check if the username exists.
How can we verify it:
Set CODEBOX_ADMINS to contain your github username in a case that is different than the canonical casing.
...also the unit test verifies it works.
Todos:
Write documentationFix linting errorsready for revieworwipIs this a breaking change?: NO