vtfpp: ImageConversion::alphaToDistance: init#114
Draft
partyvan wants to merge 2 commits into
Draft
Conversation
Owner
|
Since all of this goes over my head and is relatively self-contained, if you can move the additions here to a new header/cpp/namespace I will merge as soon as you're done without my usual nitpicking and just pretend the files don't exist besides setting up language bindings. This is awesome btw and I'm glad you came back to this and sent it in, thanks!!! |
Contributor
Author
|
there we go it's been put in its containment chamber with some snacks -- namespace name and so on seem all right to you? |
Owner
|
Looks good thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i accidentally invented an extremely niche novel dithering algorithm too oops
putting this out there for style/sanity/etc checks while i come up with test cases and maretf flags