[ENH] add preproc workflow for anat with several sessions#1191
Open
Remi-Gau wants to merge 5 commits intocpp-lln-lab:mainfrom
Open
[ENH] add preproc workflow for anat with several sessions#1191Remi-Gau wants to merge 5 commits intocpp-lln-lab:mainfrom
Remi-Gau wants to merge 5 commits intocpp-lln-lab:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
PR Type: Enhancement
PR Summary: The pull request introduces an enhancement to the preprocessing workflow for anatomical images with several sessions. It includes updates to the Makefile for data retrieval from OpenNeuro datasets and modifications to a Python script for creating dummy datasets to accommodate multiple sessions.
Decision: Comment
📝 Type: 'Enhancement' - not supported yet.
- Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
📝 Complexity: the changes are too large or complex for Sourcery to approve.
- Unsupported files: the diff contains files that Sourcery does not currently support during reviews.
General suggestions:
- Ensure that the increase in parallelism for data retrieval commands is well-tested on the target hardware to prevent potential performance bottlenecks.
- Consider removing or documenting the commented-out lines for 'func' and 'fmap' data retrieval to maintain code clarity and avoid confusion.
- Verify that the changes made are consistent with the intended use cases and that they do not introduce any unintended side effects.
Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨
Contributor
Author
|
probably worth considering a separate workflow to process anat separately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.