[2026-03 LWG Motion 28] P3826R5 Fix Sender Algorithm Customization#8919
Draft
eisenwave wants to merge 1 commit intocplusplus:mainfrom
Draft
[2026-03 LWG Motion 28] P3826R5 Fix Sender Algorithm Customization#8919eisenwave wants to merge 1 commit intocplusplus:mainfrom
eisenwave wants to merge 1 commit intocplusplus:mainfrom
Conversation
Fixes NB US 207-328, US 202-326, FR-031-219, FI-331, and CA-358 (C++26 CD).
Member
Author
|
As mentioned on the issue, this PR has a merge conflict with #8818. Some heavy massaging may be needed. |
ericniebler
reviewed
Apr 7, 2026
Contributor
ericniebler
left a comment
ericniebler
left a comment
There was a problem hiding this comment.
i know this pr is incomplete. i'll come back and review the rest when its done.
| struct @\libglobal{get_forward_progress_guarantee_t}@ { @\unspec@ }; | ||
| template<class CPO> | ||
| struct @\libglobal{get_completion_scheduler_t}@ { @\unspec@ }; | ||
| template<class CPO> |
Contributor
There was a problem hiding this comment.
Suggested change
| template<class CPO> | |
| template<class CPO = void> |
| For subexpressions \tcode{q} and \tcode{tag} and pack \tcode{args}, | ||
| let \tcode{\exposid{HIDE-SCHED}(q)} be an object \tcode{o} such that | ||
| \tcode{o.query(\brk{}tag, args...)} is ill-formed when the decayed type of \tcode{tag} is | ||
| \tcode{get_scheduler_t} or \tcode{get_domain_t}, and |
Contributor
| of the following expressions that is well-formed: | ||
| \begin{itemize} | ||
| \item \tcode{auto(\exposid{AS-CONST}(env).query(get_domain))}. | ||
| \item \tcode{get_completion_domain<set_value_t>(get_scheduler(env), \exposid{HIDE-SCHED}(env))}. |
Contributor
There was a problem hiding this comment.
NB: another merge conflict with #8925. s/get_scheduler/get_start_scheduler/
| but if \tcode{fn}'s evaluation is potentially throwing, | ||
| \tcode{sndr}'s \tcode{set_error} completion domain tag would be | ||
| the \exposid{COMMON-DOMAIN} of \tcode{sndr}'s value and error completion domain tags, | ||
| in accordance with the semantics of the then algorithm\iref{exec.then}. |
Contributor
There was a problem hiding this comment.
Suggested change
| in accordance with the semantics of the then algorithm\iref{exec.then}. | |
| in accordance with the semantics of the \tcode{then} algorithm\iref{exec.then}. |
| \tcode{\exposid{SCHED-ENV}(sch)} is an expression \tcode{o} | ||
| whose type satisfies \exposconcept{queryable} | ||
| such that \tcode{o2.query(get_scheduler)} is a prvalue | ||
| such that \tcode{o.query(\brk{}get_scheduler)} is a prvalue |
Contributor
There was a problem hiding this comment.
another conflict with #8925 here: get_scheduler should be get_start_scheduler.
| \pnum | ||
| For a subexpression \tcode{env}, | ||
| \tcode{\exposid{inline-attrs}<Tag>{}.query(get_completion_scheduler<Tag>, env)} | ||
| is expres\-sion-equivalent to \tcode{get_scheduler(env)}. |
Contributor
There was a problem hiding this comment.
another s/get_scheduler/get_start_scheduler/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8862
Fixes NB US 207-328, US 202-326, FR-031-219, FI-331, and CA-358 (C++26 CD).
Also fixes cplusplus/papers#2448
Also fixes https://github.com/cplusplus/nbballot/issues/903
Also fixes https://github.com/cplusplus/nbballot/issues/901
Also fixes https://github.com/cplusplus/nbballot/issues/894
Also fixes https://github.com/cplusplus/nbballot/issues/906
Also fixes https://github.com/cplusplus/nbballot/issues/933