Update fees.md#628
Conversation
adjusted the fee to 1% on limit orders and market orders
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughWalkthroughUpdated fee documentation in the CoW Protocol by adjusting surplus and quote-improvement fee definitions to reference a 1% total volume cap, updating the quote-improvement fee formula to use ChangesFee Definitions
🎯 1 (Trivial) | ⏱️ ~3 minutes
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/governance/fees/fees.md`:
- Line 19: The doc currently says "capped at 1% of the total volume" under the
Definition block but the formula uses `volume * 0.0098`; update the formula to
match the stated cap by replacing `volume * 0.0098` with `volume * 0.01` and
ensure the surrounding text (the "Definition:" line stating 50% of surplus ...
capped at 1%) remains consistent with that formula.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 1574363c-7b29-4689-be96-0961d42e44ab
📒 Files selected for processing (1)
docs/governance/fees/fees.md
| ### Surplus fee on out-of-market limit orders | ||
|
|
||
| > **Definition:** 50% of surplus on out-of-market limit orders, capped at 0.98% of the total volume of the order | ||
| > **Definition:** 50% of surplus on out-of-market limit orders, capped at 1% of the total volume of the order |
There was a problem hiding this comment.
Surplus fee cap text and formula conflict (1% vs 0.98%).
Line 19 states a 1% cap, but the surplus fee formula in this block uses volume * 0.0098. Please align them to one cap value; otherwise users may compute different fees from the same section.
Proposed doc fix (if cap is truly 1%)
-> **Fee calculation:** surplus \* 0.5 **OR** volume \* 0.0098 [whichever number is lower]
+> **Fee calculation:** surplus \* 0.5 **OR** volume \* 0.01 [whichever number is lower]🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/governance/fees/fees.md` at line 19, The doc currently says "capped at
1% of the total volume" under the Definition block but the formula uses `volume
* 0.0098`; update the formula to match the stated cap by replacing `volume *
0.0098` with `volume * 0.01` and ensure the surrounding text (the "Definition:"
line stating 50% of surplus ... capped at 1%) remains consistent with that
formula.
adjusted the fee to 1% on limit orders and market orders
Description
Changes
Summary by CodeRabbit