Add deletion of a key with CAS value (DelCas)#4
Open
adamliesko wants to merge 1 commit intocouchbase:masterfrom
Open
Add deletion of a key with CAS value (DelCas)#4adamliesko wants to merge 1 commit intocouchbase:masterfrom
adamliesko wants to merge 1 commit intocouchbase:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order, to be able to use Delete with CAS in go-couchbase client, we had to add CAS based deletion to the gomemcached client. PR to the go-couchbase is incoming, once this gets merged.
The behaviour for the deletion in memcached binary protocol seems to be undefined, but in couchbase it's a valid parameter implemented in some of it's clients. As this is a forked version of gomemcached, living under couchbase, I assumed it's safe.
https://groups.google.com/forum/#!searchin/memcached/cas$20delete%7Csort:relevance/memcached/eWs-mbyQuew/2nmYCd2-V3kJ