feat: integrate with subsecond #426
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C-lib
|
Bencher Report| Branch | subsecond-new |
| Testbed | github-ubuntu-latest |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result microseconds (µs) (Result Δ%) | Upper Boundary microseconds (µs) (Limit %) |
|---|---|---|---|
| empty_router/empty_router | 📈 view plot 🚷 view threshold | 6,497.50 µs(+6.86%)Baseline: 6,080.32 µs | 6,818.74 µs (95.29%) |
| json_api/json_api | 📈 view plot 🚷 view threshold | 1,042.70 µs(+1.76%)Baseline: 1,024.71 µs | 1,128.68 µs (92.38%) |
| nested_routers/nested_routers | 📈 view plot 🚷 view threshold | 961.84 µs(+1.44%)Baseline: 948.22 µs | 1,040.59 µs (92.43%) |
| single_root_route/single_root_route | 📈 view plot 🚷 view threshold | 928.29 µs(+2.23%)Baseline: 908.00 µs | 994.35 µs (93.36%) |
| single_root_route_burst/single_root_route_burst | 📈 view plot 🚷 view threshold | 17,456.00 µs(-1.64%)Baseline: 17,746.75 µs | 20,805.09 µs (83.90%) |
m4tx
force-pushed
the
subsecond-new
branch
4 times, most recently
from
80bb867 to
c1cf5a6
Compare
github-actions
bot
added
the
C-cli
seqre
reviewed
Dec 28, 2025
| ); | ||
| } | ||
| Err(_err) => { | ||
| tokio::time::sleep(std::time::Duration::from_millis(50)).await; |
Member
There was a problem hiding this comment.
nit: please extract this magic value to properly named constant
This allows us to implement hot patching for the request handlers. More details: https://docs.rs/subsecond/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to implement hot patching for the request handlers. More details: https://docs.rs/subsecond/